merge: mark .hgsubstate as possibly dirty before submerge for consistency Before this patch, failure of updating subrepos may cause inconsistent ".hgsubstate". For example: 1. dirstate entry for ".hgsubstate" of the parent repo is filled with valid size/date (via "hg state" or so) 2. "hg update" is invoked at the parent repo 3. ".hgsubstate" of the parent repo is updated on the filesystem as a part of "g"(et) action in "merge.applyupdates" 4. it is assumed that size/date of ".hgsubstate" on the filesystem aren't changed from ones at (1) this is not so difficult condition, because just changing hash ids (every ids are same in length) in ".hgsubstate" doesn't change the file size of it 5. "subrepo.submerge()" is invoked to update subrepos 6. failure of updating in one of subrepos raises exception (e.g. "untracked file differs") 7. "hg update" is aborted without updating dirstate of the parent repo dirstate entry for ".hgsubstate" still holds size/date at (1) Then, ".hgsubstate" of the parent repo is treated as "CLEAN" unexpectedly, because updating ".hgsubstate" at (3) doesn't change size/date of it on the filesystem: see assumption at (4). This inconsistent ".hgsubstate" status causes unexpected behavior, for example: - "hg revert" forgets to revert ".hgsubstate" - "hg update" misunderstands that (not yet updated) subrepos diverge (then, it shows the prompt to confirm user's decision) To avoid inconsistent ".hgsubstate" status above, this patch marks ".hgsubstate" as possibly dirty before "submerge" invocation. "normallookup"-ed (= dirty) dirstate should be written out, even if processing is aborted by failure. This patch marks ".hgsubstate" as possibly dirty before "submerge", also when it is removed or merged while merging, for safety. This should prevent Mercurial from misunderstanding inconsistent ".hgsubstate" as clean. To satisfy conditions at (1) and (4) above, this patch uses "hg status --config debug.dirstate.delaywrite=2" (to fill valid size/date into dirstate) and "touch" (to fix date of the file).

     1

import os

     2

from mercurial import hg, ui

     3

from mercurial.scmutil import walkrepos

     4

from mercurial.util import checklink

     5

from os import mkdir, chdir

     6

from os.path import join as pjoin

     7

     8

u = ui.ui()

     9

sym = checklink('.')

    10

    11

hg.repository(u, 'top1', create=1)

    12

mkdir('subdir')

    13

chdir('subdir')

    14

hg.repository(u, 'sub1', create=1)

    15

mkdir('subsubdir')

    16

chdir('subsubdir')

    17

hg.repository(u, 'subsub1', create=1)

    18

chdir(os.path.pardir)

    19

if sym:

    20

    os.symlink(os.path.pardir, 'circle')

    21

    os.symlink(pjoin('subsubdir', 'subsub1'), 'subsub1')

    22

    23

def runtest():

    24

    reposet = frozenset(walkrepos('.', followsym=True))

    25

    if sym and (len(reposet) != 3):

    26

        print "reposet = %r" % (reposet,)

    27

        print ("Found %d repositories when I should have found 3"

    28

               % (len(reposet),))

    29

    if (not sym) and (len(reposet) != 2):

    30

        print "reposet = %r" % (reposet,)

    31

        print ("Found %d repositories when I should have found 2"

    32

               % (len(reposet),))

    33

    sub1set = frozenset((pjoin('.', 'sub1'),

    34

                         pjoin('.', 'circle', 'subdir', 'sub1')))

    35

    if len(sub1set & reposet) != 1:

    36

        print "sub1set = %r" % (sub1set,)

    37

        print "reposet = %r" % (reposet,)

    38

        print "sub1set and reposet should have exactly one path in common."

    39

    sub2set = frozenset((pjoin('.', 'subsub1'),

    40

                         pjoin('.', 'subsubdir', 'subsub1')))

    41

    if len(sub2set & reposet) != 1:

    42

        print "sub2set = %r" % (sub2set,)

    43

        print "reposet = %r" % (reposet,)

    44

        print "sub2set and reposet should have exactly one path in common."

    45

    sub3 = pjoin('.', 'circle', 'top1')

    46

    if sym and sub3 not in reposet:

    47

        print "reposet = %r" % (reposet,)

    48

        print "Symbolic links are supported and %s is not in reposet" % (sub3,)

    49

    50

runtest()

    51

if sym:

    52

    # Simulate not having symlinks.

    53

    del os.path.samestat

    54

    sym = False

    55

    runtest()