fix: use scmutil.movedirstate() instead of reimplementing I wrote this patch 2 years ago as a little cleanup. I wanted to generally used `scmutil.movedirstate()` instead of manually updating the dirstate because that is easy to get wrong. I didn't know until today that the current code had a bug. So I added the test case two patches before this one and dusted off this one patch. This is a little slower than the previous code, as it diffs two manifests. However, it fixes the bug and I don't think it's going to be noticeably slower anyway. Differential Revision: https://phab.mercurial-scm.org/D11210

     1

Our full contribution guidelines are in our wiki, please see:

     2

     3

https://www.mercurial-scm.org/wiki/ContributingChanges

     4

     5

If you just want a checklist to follow, you can go straight to

     6

     7

https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

     8

     9

If you can't run the entire testsuite for some reason (it can be

    10

difficult on Windows), please at least run `contrib/check-code.py` on

    11

any files you've modified and run `python contrib/check-commit` on any

    12

commits you've made (for example, `python contrib/check-commit

    13

273ce12ad8f1` will report some style violations on a very old commit).