revert: evaluate filesets against working directory (issue4497) As the failing revert tests in test-fileset-generated.t show, Revert currently creates one matcher for matching files in the working copy and another matcher for matching files in the target revision. The two matchers are created with different contexts, which means filesets are evaluated differently. Then the union of the sets of files matching the matchers in the two contexts are reverted. It doesn't seem to make sense to use two different matchers; only the context they're applied to should be different. It seems very likely that the user wants the filesets to be evaluated against the working directory, which the tests test-fileset-generated.t also assume, so let's make it so. I willingly admit that the largefiles code was modified by trial and error (according to tests).

     1

  $ hg init

     2

  $ touch a

     3

  $ hg add a

     4

  $ hg ci -m "a"

     5

     6

  $ echo 123 > b

     7

  $ hg add b

     8

  $ hg diff --nodates

     9

  diff -r 3903775176ed b

    10

  --- /dev/null

    11

  +++ b/b

    12

  @@ -0,0 +1,1 @@

    13

  +123

    14

    15

  $ hg diff --nodates -r tip

    16

  diff -r 3903775176ed b

    17

  --- /dev/null

    18

  +++ b/b

    19

  @@ -0,0 +1,1 @@

    20

  +123

    21

    22

  $ echo foo > a

    23

  $ hg diff --nodates

    24

  diff -r 3903775176ed a

    25

  --- a/a

    26

  +++ b/a

    27

  @@ -0,0 +1,1 @@

    28

  +foo

    29

  diff -r 3903775176ed b

    30

  --- /dev/null

    31

  +++ b/b

    32

  @@ -0,0 +1,1 @@

    33

  +123

    34

    35

  $ hg diff -r ""

    36

  hg: parse error: empty query

    37

  [255]

    38

  $ hg diff -r tip -r ""

    39

  hg: parse error: empty query

    40

  [255]