verify: replace _validpath() by matcher The verifier calls out to _validpath() to check if it should verify that path and the narrowhg extension overrides _validpath() to tell the verifier to skip that path. In treemanifest repos, the verifier calls the same method to check if it should visit a directory. However, the decision to visit a directory is different from the condition that it's a matching path, and narrowhg was working around it by returning True from its _validpath() override if *either* was true. Similar to how one can do "hg files -I foo/bar/ -X foo/" (making the include pointless), narrowhg can be configured to track the same paths. In that case match("foo/bar/baz") would be false, but match.visitdir("foo/bar/baz") turns out to be true, causing verify to fail. This may seem like a bug in visitdir(), but it's explicitly documented to be undefined for subdirectories of excluded directories. When using treemanifests, the walk would not descend into foo/, so verification would pass. However, when using flat manifests, there is no recursive directory walk and the file path "foo/bar/baz" would be passed to _validpath() without "foo/" (actually without the slash) being passed first. As explained above, _validpath() would return true for the file path and "hg verify" would fail. Replacing the _validpath() method by a matcher seems like the obvious fix. Narrowhg can then pass in its own matcher and not have to conflate the two matching functions (for dirs and files). I think it also makes the code clearer.

     1

  $ hg init

     2

  $ echo This is file a1 > a

     3

  $ hg add a

     4

  $ hg commit -m "commit #0"

     5

  $ echo This is file b1 > b

     6

  $ hg add b

     7

  $ hg commit -m "commit #1"

     8

  $ hg update 0

     9

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    10

  $ echo This is file c1 > c

    11

  $ hg add c

    12

  $ hg commit -m "commit #2"

    13

  created new head

    14

  $ hg merge 1

    15

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    16

  (branch merge, don't forget to commit)

    17

  $ rm b

    18

  $ echo This is file c22 > c

    19

    20

Test hg behaves when committing with a missing file added by a merge

    21

    22

  $ hg commit -m "commit #3"

    23

  abort: cannot commit merge with missing files

    24

  [255]

    25