record: prevent commits that don't pick up dirty subrepo changes (issue6102) This path covers interactive mode for commit, amend, and shelve, as well as the deprecated record extension. Since shelf creation uses commit without -S in the non-interactive case, aborting here should be OK. (I didn't check what happens to non interactive shelve creation if `ui.commitsubrepos=True` is set.) subrepoutil.precommit() will abort on a dirty subrepo if the config option isn't set, but the hint recommends using --subrepos to commit. Since only the commit command currently supports that option, the error has to be raised here to omit the hint. Doing the check before asking about all of the hunks in the MQ test seems like an improvement on its own. There's probably an additional check on this path that can be removed.

     1

{

     2

    // Enforcing

     3

    "eqeqeq"        : true,     // true: Require triple equals (===) for comparison

     4

    "forin"         : true,     // true: Require filtering for..in loops with obj.hasOwnProperty()

     5

    "freeze"        : true,     // true: prohibits overwriting prototypes of native objects such as Array, Date etc.

     6

    "nonbsp"        : true,     // true: Prohibit "non-breaking whitespace" characters.

     7

    "undef"         : true,     // true: Require all non-global variables to be declared (prevents global leaks)

     8

     9

    // Environments

    10

    "browser"       : true      // Web Browser (window, document, etc)

    11

}