worker: stop relying on garbage collection to release memoryview On CPython, before resizing the bytearray, all memoryviews referencing it must be released. Before this change, we ensured that all references to them were deleted. On CPython, this was enough to set the reference count to zero, which results in garbage collecting and releasing them. On PyPy, releasing the memoryviews is not necessary because they are implemented differently. If it would be necessary however, ensuring that all references are deleted would not be suffient because PyPy doesn’t use reference counting. By using with statements that take care of releasing the memoryviews, we ensure that the bytearray is resizable without relying on implementation details. So while this doesn’t fix any observable bug, it increases compatiblity with other and future Python implementations.

     1

---

     2

name: Official Review

     3

about: Submit a series for review

     4

---

     5

     6

/assign_reviewer @mercurial.review

     7

     8

Welcome to the Mercurial Merge Request creation process:

     9

    10

* Set a simple title for your MR,

    11

* All important information should be contained in your changesets' content or description,

    12

* You can add some workflow-relevant information here (eg: when this depends on another MR),

    13

* If your changes are not ready for review yet, click `Start the title with Draft:` under the title.

    14

    15

More details here:

    16

    17

* https://www.mercurial-scm.org/wiki/ContributingChanges

    18

* https://www.mercurial-scm.org/wiki/Heptapod