hgweb: do not ignore [auth] if url has a username (issue2822) The [auth] section was ignored when handling URLs like: http://user@example.com/foo Instead, we look in [auth] for an entry matching the URL and supplied user name. Entries without username can match URL with a username. Prefix length ties are resolved in favor of entries matching the username. With: foo.prefix = http://example.org foo.username = user foo.password = password bar.prefix = http://example.org/bar and the input URL: http://user@example.org/bar the 'bar' entry will be selected because of prefix length, therefore prompting for a password. This behaviour ensure that entries selection is consistent when looking for credentials or for certificates, and that certificates can be picked even if their entries do no define usernames while the URL does. Additionally, entries without a username matched against a username are returned as if they did have requested username set to avoid prompting again for a username if the password is not set. v2: reparse the URL in readauthforuri() to handle HTTP and HTTPS similarly. v3: allow unset usernames to match URL usernames to pick certificates. Resolve prefix length ties in favor of entries with usernames.

     1

  $ echo "[extensions]" >> $HGRCPATH

     2

  $ echo "mq=" >> $HGRCPATH

     3

     4

  $ hg init a

     5

  $ cd a

     6

  $ echo a > a

     7

  $ hg ci -Ama

     8

  adding a

     9

    10

  $ hg qnew a.patch

    11

  $ echo a >> a

    12

  $ hg qrefresh

    13

    14

  $ hg qnew b.patch

    15

  $ echo b > b

    16

  $ hg add b

    17

  $ hg qrefresh

    18

    19

  $ hg qnew c.patch

    20

  $ echo c > c

    21

  $ hg add c

    22

  $ hg qrefresh

    23

    24

  $ hg qgoto a.patch

    25

  popping c.patch

    26

  popping b.patch

    27

  now at: a.patch

    28

    29

  $ hg qgoto c.patch

    30

  applying b.patch

    31

  applying c.patch

    32

  now at: c.patch

    33

    34

  $ hg qgoto b.patch

    35

  popping c.patch

    36

  now at: b.patch

    37

    38

Using index:

    39

    40

  $ hg qgoto 0

    41

  popping b.patch

    42

  now at: a.patch

    43

    44

  $ hg qgoto 2

    45

  applying b.patch

    46

  applying c.patch

    47

  now at: c.patch

    48

    49

No warnings when using index:

    50

    51

  $ hg qnew bug314159

    52

  $ echo d >> c

    53

  $ hg qrefresh

    54

  $ hg qnew bug141421

    55

  $ echo e >> c

    56

  $ hg qrefresh

    57

    58

  $ hg qgoto 1

    59

  popping bug141421

    60

  popping bug314159

    61

  popping c.patch

    62

  now at: b.patch

    63

    64

  $ hg qgoto 3

    65

  applying c.patch

    66

  applying bug314159

    67

  now at: bug314159

    68

    69

Detect ambiguous non-index:

    70

    71

  $ hg qgoto 14

    72

  patch name "14" is ambiguous:

    73

    bug314159

    74

    bug141421

    75

  abort: patch 14 not in series

    76

  [255]

    77