profile: upgrade the "profile" context manager to a full class So far we have been able to use a simple decorator for this. However using the current context manager makes the scope of the profiling in dispatch constrainted and the time frame to decide to enable profiling quite limited (using "maybeprofile") This is the first step toward the ability to enable the profiling from within the profiling scope. eg:: with maybeprofiling(ui) as profiler: ... bar.foo(): ... if options['profile']: profiler.start() ... fooz() ... My target usecase is adding support for "--profile" to alias definitions with effect. These are to be used with "profiling.output=blackbox" to gather data about operation that get slow from time to time (eg: pull being minutes instead of seconds from time to time). Of course, in such case, the scope of the profiling would be smaller since profiler would be started after running extensions 'reposetup' (and other potentially costly logic), but these are not relevant for my target usecase (multiple second commits, multiple tens of seconds pull). Currently adding '--profile' to a command through alias requires to re-spin a Mercurial binary (using "!$HG" in alias), which as a significant performance impact, especially in context where startup performance is being worked on... An alternative approach would be to stop using the context manager in dispatch and move back to a try/finally setup.

     1

#!/bin/bash -e

     2

     3

. $(dirname $0)/dockerlib.sh

     4

     5

BUILDDIR=$(dirname $0)

     6

export ROOTDIR=$(cd $BUILDDIR/..; pwd)

     7

     8

checkdocker

     9

    10

PLATFORM="$1"

    11

shift # extra params are passed to buildrpm

    12

    13

initcontainer $PLATFORM

    14

    15

RPMBUILDDIR=$ROOTDIR/packages/$PLATFORM

    16

contrib/buildrpm --rpmbuilddir $RPMBUILDDIR --prepare $*

    17

    18

DSHARED=/mnt/shared

    19

$DOCKER run -u $DBUILDUSER --rm -v $RPMBUILDDIR:$DSHARED $CONTAINER \

    20

    rpmbuild --define "_topdir $DSHARED" -ba $DSHARED/SPECS/mercurial.spec --clean

    21

    22

$DOCKER run -u $DBUILDUSER --rm -v $RPMBUILDDIR:$DSHARED $CONTAINER \

    23

    createrepo $DSHARED

    24

    25

cat << EOF > $RPMBUILDDIR/mercurial.repo

    26

# Place this file in /etc/yum.repos.d/mercurial.repo

    27

[mercurial]

    28

name=Mercurial packages for $PLATFORM

    29

# baseurl=file://$RPMBUILDDIR/

    30

baseurl=http://hg.example.com/build/$PLATFORM/

    31

skip_if_unavailable=True

    32

gpgcheck=0

    33

enabled=1

    34

EOF

    35

    36

echo

    37

echo "Build complete - results can be found in $RPMBUILDDIR"