profile: upgrade the "profile" context manager to a full class So far we have been able to use a simple decorator for this. However using the current context manager makes the scope of the profiling in dispatch constrainted and the time frame to decide to enable profiling quite limited (using "maybeprofile") This is the first step toward the ability to enable the profiling from within the profiling scope. eg:: with maybeprofiling(ui) as profiler: ... bar.foo(): ... if options['profile']: profiler.start() ... fooz() ... My target usecase is adding support for "--profile" to alias definitions with effect. These are to be used with "profiling.output=blackbox" to gather data about operation that get slow from time to time (eg: pull being minutes instead of seconds from time to time). Of course, in such case, the scope of the profiling would be smaller since profiler would be started after running extensions 'reposetup' (and other potentially costly logic), but these are not relevant for my target usecase (multiple second commits, multiple tens of seconds pull). Currently adding '--profile' to a command through alias requires to re-spin a Mercurial binary (using "!$HG" in alias), which as a significant performance impact, especially in context where startup performance is being worked on... An alternative approach would be to stop using the context manager in dispatch and move back to a try/finally setup.

     1

HG = $(CURDIR)/../../hg

     2

     3

TARGET = chg

     4

SRCS = chg.c hgclient.c procutil.c util.c

     5

OBJS = $(SRCS:.c=.o)

     6

     7

CFLAGS ?= -O2 -Wall -Wextra -pedantic -g

     8

CPPFLAGS ?= -D_FORTIFY_SOURCE=2

     9

override CFLAGS += -std=gnu99

    10

ifdef HGPATH

    11

override CPPFLAGS += -DHGPATH=\"$(HGPATH)\"

    12

endif

    13

    14

DESTDIR =

    15

PREFIX = /usr/local

    16

MANDIR = $(PREFIX)/share/man/man1

    17

    18

CHGSOCKDIR = /tmp/chg$(shell id -u)

    19

CHGSOCKNAME = $(CHGSOCKDIR)/server

    20

    21

.PHONY: all

    22

all: $(TARGET)

    23

    24

$(TARGET): $(OBJS)

    25

	$(CC) $(LDFLAGS) -o $@ $(OBJS)

    26

    27

chg.o: hgclient.h procutil.h util.h

    28

hgclient.o: hgclient.h procutil.h util.h

    29

procutil.o: procutil.h util.h

    30

util.o: util.h

    31

    32

.PHONY: install

    33

install: $(TARGET)

    34

	install -d $(DESTDIR)$(PREFIX)/bin

    35

	install -m 755 $(TARGET) $(DESTDIR)$(PREFIX)/bin

    36

	install -d $(DESTDIR)$(MANDIR)

    37

	install -m 644 chg.1 $(DESTDIR)$(MANDIR)

    38

    39

.PHONY: serve

    40

serve:

    41

	[ -d $(CHGSOCKDIR) ] || ( umask 077; mkdir $(CHGSOCKDIR) )

    42

	$(HG) serve --cwd / --cmdserver chgunix \

    43

		--address $(CHGSOCKNAME) \

    44

		--config cmdserver.log=/dev/stderr

    45

    46

.PHONY: clean

    47

clean:

    48

	$(RM) $(OBJS)

    49

    50

.PHONY: distclean

    51

distclean:

    52

	$(RM) $(OBJS) $(TARGET)