wireprotov2: change how revisions are specified to changesetdata Right now, we have a handful of arguments for specifying the revisions whose data should be returned. Defining how all these arguments interact when various combinations are present is difficult. This commit establishes a new, generic mechanism for specifying revisions. Instead of a hodgepodge of arguments defining things, we have a list of dicts that specify revision selectors. The final set of revisions is a union of all these selectors. We implement support for specifying revisions based on: * An explicit list of changeset revisions * An explicit list of changeset revisions plus ancestry depth * A DAG range between changeset roots and heads If you squint hard enough, this problem has already been solved by revsets. But I'm reluctant to expose revsets to the wire protocol because that would require servers to implement a revset parser. Plus there are security and performance implications: the set of revision selectors needs to be narrowly and specifically tailored for what is appropriate to be executing on a server. Perhaps there would be a way for us to express the "parse tree" of a revset query, for example. I'm not sure. We can explore this space another time. For now, the new mechanism should bring sufficient flexibility while remaining relatively simple. The selector "types" are prefixed with "changeset" because I plan to add manifest and file-flavored selectors as well. This will enable us to e.g. select file revisions based on a range of changeset revisions. Differential Revision: https://phab.mercurial-scm.org/D4979

     1

     2

  $ . "$TESTDIR/narrow-library.sh"

     3

     4

create full repo

     5

     6

  $ hg init master

     7

  $ cd master

     8

     9

  $ mkdir inside

    10

  $ echo inside > inside/f1

    11

  $ mkdir outside

    12

  $ echo outside > outside/f2

    13

  $ hg ci -Aqm 'initial'

    14

    15

  $ hg mv outside/f2 inside/f2

    16

  $ hg ci -qm 'move f2 from outside'

    17

    18

  $ echo modified > inside/f2

    19

  $ hg ci -qm 'modify inside/f2'

    20

    21

  $ cd ..

    22

    23

  $ hg clone --narrow ssh://user@dummy/master narrow --include inside

    24

  requesting all changes

    25

  adding changesets

    26

  adding manifests

    27

  adding file changes

    28

  added 3 changesets with 3 changes to 2 files

    29

  new changesets *:* (glob)

    30

  updating to branch default

    31

  2 files updated, 0 files merged, 0 files removed, 0 files unresolved

    32

  $ cd narrow

    33

    34

  $ hg co 'desc("move f2")'

    35

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    36

  $ hg status

    37

  $ hg diff

    38

  $ hg diff --change . --git

    39

  diff --git a/inside/f2 b/inside/f2

    40

  new file mode 100644

    41

  --- /dev/null

    42

  +++ b/inside/f2

    43

  @@ -0,0 +1,1 @@

    44

  +outside

    45

    46

  $ hg log --follow inside/f2 -r tip

    47

  changeset:   2:bcfb756e0ca9

    48

  tag:         tip

    49

  user:        test

    50

  date:        Thu Jan 01 00:00:00 1970 +0000

    51

  summary:     modify inside/f2

    52

    53

  changeset:   1:5a016133b2bb

    54

  user:        test

    55

  date:        Thu Jan 01 00:00:00 1970 +0000

    56

  summary:     move f2 from outside

    57