wireprotov2: change how revisions are specified to changesetdata Right now, we have a handful of arguments for specifying the revisions whose data should be returned. Defining how all these arguments interact when various combinations are present is difficult. This commit establishes a new, generic mechanism for specifying revisions. Instead of a hodgepodge of arguments defining things, we have a list of dicts that specify revision selectors. The final set of revisions is a union of all these selectors. We implement support for specifying revisions based on: * An explicit list of changeset revisions * An explicit list of changeset revisions plus ancestry depth * A DAG range between changeset roots and heads If you squint hard enough, this problem has already been solved by revsets. But I'm reluctant to expose revsets to the wire protocol because that would require servers to implement a revset parser. Plus there are security and performance implications: the set of revision selectors needs to be narrowly and specifically tailored for what is appropriate to be executing on a server. Perhaps there would be a way for us to express the "parse tree" of a revset query, for example. I'm not sure. We can explore this space another time. For now, the new mechanism should bring sufficient flexibility while remaining relatively simple. The selector "types" are prefixed with "changeset" because I plan to add manifest and file-flavored selectors as well. This will enable us to e.g. select file revisions based on a range of changeset revisions. Differential Revision: https://phab.mercurial-scm.org/D4979

     1

from __future__ import absolute_import, print_function

     2

     3

# Import something from Mercurial, so the module loader gets initialized.

     4

from mercurial import pycompat

     5

del pycompat  # unused for now

     6

     7

from hgext.lfs import pointer

     8

     9

def tryparse(text):

    10

    r = {}

    11

    try:

    12

        r = pointer.deserialize(text)

    13

        print('ok')

    14

    except Exception as ex:

    15

        print((b'%s' % ex).decode('ascii'))

    16

    if r:

    17

        text2 = r.serialize()

    18

        if text2 != text:

    19

            print('reconstructed text differs')

    20

    return r

    21

    22

t = (b'version https://git-lfs.github.com/spec/v1\n'

    23

     b'oid sha256:4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1'

    24

     b'258daaa5e2ca24d17e2393\n'

    25

     b'size 12345\n'

    26

     b'x-foo extra-information\n')

    27

    28

tryparse(b'')

    29

tryparse(t)

    30

tryparse(t.replace(b'git-lfs', b'unknown'))

    31

tryparse(t.replace(b'v1\n', b'v1\n\n'))

    32

tryparse(t.replace(b'sha256', b'ahs256'))

    33

tryparse(t.replace(b'sha256:', b''))

    34

tryparse(t.replace(b'12345', b'0x12345'))

    35

tryparse(t.replace(b'extra-information', b'extra\0information'))

    36

tryparse(t.replace(b'extra-information', b'extra\ninformation'))

    37

tryparse(t.replace(b'x-foo', b'x_foo'))

    38

tryparse(t.replace(b'oid', b'blobid'))

    39

tryparse(t.replace(b'size', b'size-bytes').replace(b'oid', b'object-id'))