ssh: unban the use of pipe character in user@host:port string This vulnerability was fixed by the previous patch and there were more ways to exploit than using '|shellcmd'. So it doesn't make sense to reject only pipe character. Test cases are updated to actually try to exploit the bug. As the SSH bridge of git/svn subrepos are not managed by our code, the tests for non-hg subrepos are just removed. This may be folded into the original patches.

     1

  $ hg init

     2

     3

  $ $PYTHON -c 'open("a", "wb").write(b"confuse str.splitlines\nembedded\rnewline\n")'

     4

  $ hg ci -Ama -d '1 0'

     5

  adding a

     6

     7

  $ echo clean diff >> a

     8

  $ hg ci -mb -d '2 0'

     9

    10

  $ hg diff -r0 -r1

    11

  diff -r 107ba6f817b5 -r 310ce7989cdc a

    12

  --- a/a	Thu Jan 01 00:00:01 1970 +0000

    13

  +++ b/a	Thu Jan 01 00:00:02 1970 +0000

    14

  @@ -1,2 +1,3 @@

    15

   confuse str.splitlines

    16

   embedded\r (no-eol) (esc)

    17

  newline

    18

  +clean diff

    19