exchange: refactor APIs to obtain bundle data (API) Currently, exchange.getbundle() returns either a cg1unpacker or a util.chunkbuffer (in the case of bundle2). This is kinda OK, as both expose a .read() to consumers. However, localpeer.getbundle() has code inferring what the response type is based on arguments and converts the util.chunkbuffer returned in the bundle2 case to a bundle2.unbundle20 instance. This is a sign that the API for exchange.getbundle() is not ideal because it doesn't consistently return an "unbundler" instance. In addition, unbundlers mask the fact that there is an underlying generator of changegroup data. In both cg1 and bundle2, this generator is being fed into a util.chunkbuffer so it can be re-exposed as a file object. util.chunkbuffer is a nice abstraction. However, it should only be used "at the edges." This is because keeping data as a generator is more efficient than converting it to a chunkbuffer, especially if we convert that chunkbuffer back to a generator (as is the case in some code paths currently). This patch refactors exchange.getbundle() into exchange.getbundlechunks(). The new API returns an iterator of chunks instead of a file-like object. Callers of exchange.getbundle() have been updated to use the new API. There is a minor change of behavior in test-getbundle.t. This is because `hg debuggetbundle` isn't defining bundlecaps. As a result, a cg1 data stream and unpacker is being produced. This is getting fed into a new bundle20 instance via bundle2.writebundle(), which uses a backchannel mechanism between changegroup generation to add the "nbchanges" part parameter. I never liked this backchannel mechanism and I plan to remove it someday. `hg bundle` still produces the "nbchanges" part parameter, so there should be no user-visible change of behavior. I consider this "regression" a bug in `hg debuggetbundle`. And that bug is captured by an existing "TODO" in the code to use bundle2 capabilities.

     1

basic:

     2

     3

* neither file exists

     4

creating

     5

* neither file still exists

     6

* empty file x created

     7

creating

     8

* file x changed size

     9

creating

    10

* nothing changed with either file

    11

* file x changed inode

    12

creating

    13

* empty file y created

    14

creating

    15

* file y changed size

    16

creating

    17

* file y changed inode

    18

creating

    19

* both files changed inode

    20

creating

    21

    22

fakeuncacheable:

    23

    24

* neither file exists

    25

creating

    26

* neither file still exists

    27

creating

    28

* empty file x created

    29

creating

    30

* file x changed size

    31

creating

    32

* nothing changed with either file

    33

creating

    34

* file x changed inode

    35

creating

    36

* empty file y created

    37

creating

    38

* file y changed size

    39

creating

    40

* file y changed inode

    41

creating

    42

* both files changed inode

    43

creating

    44

repository tip rolled back to revision -1 (undo commit)

    45

working directory now based on revision -1

    46

repository tip rolled back to revision -1 (undo commit)

    47

working directory now based on revision -1

    48

    49

setbeforeget:

    50

    51

* neither file exists

    52

string set externally

    53

* file x created

    54

creating

    55

string from function

    56

* string set externally again

    57

string 2 set externally

    58

* file y created

    59

creating

    60

string from function

    61

    62

antiambiguity:

    63