parsers: fail fast if Python has wrong minor version (issue4110) This change causes an informative ImportError to be raised when importing the parsers extension module if the minor version of the currently-running Python interpreter doesn't match that of the Python used when compiling the extension module. This change also exposes a parsers.versionerrortext constant in the C implementation of the module. Its presence can be used to determine whether this behavior is present in a version of the module. The value of the constant is the leading text of the ImportError raised and is set to "Python minor version mismatch". Here is an example of what the new error looks like: Traceback (most recent call last): File "test.py", line 1, in <module> import mercurial.parsers ImportError: Python minor version mismatch: The Mercurial extension modules were compiled with Python 2.7.6, but Mercurial is currently using Python with sys.hexversion=33883888: Python 2.5.6 (r256:88840, Nov 18 2012, 05:37:10) [GCC 4.2.1 Compatible Apple Clang 4.1 ((tags/Apple/clang-421.11.66))] at: /opt/local/Library/Frameworks/Python.framework/Versions/2.5/Resources/ Python.app/Contents/MacOS/Python The reason for raising an error in this scenario is that Python's C API is known not to be compatible from minor version to minor version, even if sys.api_version is the same. See for example this Python bug report about incompatibilities between 2.5 and 2.6+: http://bugs.python.org/issue8118 These incompatibilities can cause Mercurial to break in mysterious, unforeseen ways. For example, when Mercurial compiled with Python 2.7 was run with 2.5, the following crash occurred when running "hg status": http://bz.selenic.com/show_bug.cgi?id=4110 After this crash was fixed, running with Python 2.5 no longer crashes, but the following puzzling behavior still occurs: $ hg status ... File ".../mercurial/changelog.py", line 123, in __init__ revlog.revlog.__init__(self, opener, "00changelog.i") File ".../mercurial/revlog.py", line 251, in __init__ d = self._io.parseindex(i, self._inline) File ".../mercurial/revlog.py", line 158, in parseindex index, cache = parsers.parse_index2(data, inline) TypeError: data is not a string which can be reproduced more simply with: import mercurial.parsers as parsers parsers.parse_index2("", True) Both the crash and the TypeError occurred because the Python C API's PyString_Check() returns the wrong value when the C header files from Python 2.7 are run with Python 2.5. This is an example of an incompatibility of the sort mentioned in the Python bug report above. Failing fast with an informative error message results in a better user experience in cases like the above. The information in the ImportError also simplifies troubleshooting for those on Mercurial mailing lists, the bug tracker, etc. This patch only adds the version check to parsers.c, which is sufficient to affect command-line commands like "hg status" and "hg summary". An idea for a future improvement is to move the version-checking C code to a more central location, and have it run when importing all Mercurial extension modules and not just parsers.c.

     1

#!/usr/bin/env python

     2

#

     3

# mercurial - scalable distributed SCM

     4

#

     5

# Copyright 2005-2007 Matt Mackall <mpm@selenic.com>

     6

#

     7

# This software may be used and distributed according to the terms of the

     8

# GNU General Public License version 2 or any later version.

     9

    10

import os

    11

import sys

    12

    13

libdir = '@LIBDIR@'

    14

    15

if libdir != '@' 'LIBDIR' '@':

    16

    if not os.path.isabs(libdir):

    17

        libdir = os.path.join(os.path.dirname(os.path.realpath(__file__)),

    18

                              libdir)

    19

        libdir = os.path.abspath(libdir)

    20

    sys.path.insert(0, libdir)

    21

    22

# enable importing on demand to reduce startup time

    23

try:

    24

    from mercurial import demandimport; demandimport.enable()

    25

except ImportError:

    26

    import sys

    27

    sys.stderr.write("abort: couldn't find mercurial libraries in [%s]\n" %

    28

                     ' '.join(sys.path))

    29

    sys.stderr.write("(check your install and PYTHONPATH)\n")

    30

    sys.exit(-1)

    31

    32

import mercurial.util

    33

import mercurial.dispatch

    34

    35

for fp in (sys.stdin, sys.stdout, sys.stderr):

    36

    mercurial.util.setbinary(fp)

    37

    38

mercurial.dispatch.run()