perf: clear vfs audit_cache before each run When generating a stream clone, we spend a large amount of time auditing path. Before this changes, the first run was warming the vfs cache for the other runs, leading to a large runtime difference and a "faulty" reported timing for the operation. We now clear this important cache between run to get a more realistic timing. Below are some example of median time change when clearing these cases. The maximum time for a run did not changed significantly. ### data-env-vars.name = mozilla-central-2018-08-01-zstd-sparse-revlog # benchmark.name = hg.perf.exchange.stream.generate # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.version = latest no-clearing: 17.289905 cache-clearing: 21.587965 (+24.86%, +4.30) ## data-env-vars.name = mozilla-central-2024-03-22-zstd-sparse-revlog no-clearing: 32.670748 cache-clearing: 40.467095 (+23.86%, +7.80) ## data-env-vars.name = mozilla-try-2019-02-18-zstd-sparse-revlog no-clearing: 37.838858 cache-clearing: 46.072749 (+21.76%, +8.23) ## data-env-vars.name = mozilla-unified-2024-03-22-zstd-sparse-revlog no-clearing: 32.969395 cache-clearing: 39.646209 (+20.25%, +6.68) In addition, this significantly reduce the timing difference between the performance command, from the perf extensions and a `real `hg bundle` call producing a stream bundle. Some significant differences remain especially on the "mozilla-try" repositories, but they are now smaller. Note that some of that difference will actually not be attributable to the stream generation (like maybe phases or branch map computation). Below are some benchmarks done on a currently draft changeset fixing some unrelated slowness in `hg bundle` (34a78972af409d1ff37c29e60f6ca811ad1a457d) ### data-env-vars.name = mozilla-central-2018-08-01-zstd-sparse-revlog # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default hg.perf.exchange.stream.generate: 21.587965 hg.command.bundle: 24.301799 (+12.57%, +2.71) ## data-env-vars.name = mozilla-central-2024-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 40.467095 hg.command.bundle: 44.831317 (+10.78%, +4.36) ## data-env-vars.name = mozilla-unified-2024-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 39.646209 hg.command.bundle: 45.395258 (+14.50%, +5.75) ## data-env-vars.name = mozilla-try-2019-02-18-zstd-sparse-revlog hg.perf.exchange.stream.generate: 46.072749 hg.command.bundle: 55.882608 (+21.29%, +9.81) ## data-env-vars.name = mozilla-try-2023-03-22-zlib-general-delta hg.perf.exchange.stream.generate: 334.716708 hg.command.bundle: 377.856767 (+12.89%, +43.14) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 302.972301 hg.command.bundle: 326.098755 (+7.63%, +23.13)

     1

#require serve

     2

     3

  $ hg init server

     4

  $ hg serve -R server -p $HGPORT -d --pid-file=hg1.pid -E ../error.log

     5

  $ cat hg1.pid >> $DAEMON_PIDS

     6

     7

Check basic fetching

     8

     9

  $ hg debugdownload "http://localhost:$HGPORT/?cmd=lookup&key=tip"

    10

  1 0000000000000000000000000000000000000000

    11

  $ hg debugdownload  -o null.txt "http://localhost:$HGPORT/?cmd=lookup&key=null"

    12

  $ cat null.txt

    13

  1 0000000000000000000000000000000000000000

    14

    15

Check the request is made from the usual Mercurial logic

    16

(rev details, give different content if the request has a Mercurial user agent)

    17

    18

  $ get-with-headers.py --headeronly "localhost:$HGPORT" "rev/tip" content-type

    19

  200 Script output follows

    20

  content-type: text/html; charset=ascii

    21

  $ hg debugdownload "http://localhost:$HGPORT/rev/tip"

    22

    23

  # HG changeset patch

    24

  # User 

    25

  # Date 0 0

    26

  # Node ID 0000000000000000000000000000000000000000

    27

    28

    29

    30

    31

    32

Check other kind of compatible url

    33

    34

  $ hg debugdownload ./null.txt

    35

  1 0000000000000000000000000000000000000000

    36

    37

  $ cat ../error.log

    38

    39

Test largefile URL

    40

------------------

    41

    42

  $ cat << EOF >> $HGRCPATH

    43

  > [extensions]

    44

  > largefiles=

    45

  > EOF

    46

    47

  $ killdaemons.py

    48

  $ rm -f error.log hg1.pid

    49

  $ hg serve -R server -p $HGPORT -d --pid-file=hg1.pid -E error.log

    50

  $ cat hg1.pid >> $DAEMON_PIDS

    51

    52

  $ hg -R server debuglfput null.txt

    53

  a57b57b39ee4dc3da1e03526596007f480ecdbe8

    54

    55

  $ hg debugdownload "largefile://a57b57b39ee4dc3da1e03526596007f480ecdbe8" --config paths.default=http://localhost:$HGPORT/

    56

  1 0000000000000000000000000000000000000000

    57

    58

from within a repository

    59

    60

  $ hg clone http://localhost:$HGPORT/ client

    61

  no changes found

    62

  updating to branch default

    63

  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

    64

    65

  $ cd client

    66

  $ hg path

    67

  default = http://localhost:$HGPORT/

    68

  $ hg debugdownload "largefile://a57b57b39ee4dc3da1e03526596007f480ecdbe8"

    69

  1 0000000000000000000000000000000000000000

    70

  $ cd ..

    71

    72

  $ cat error.log