perf: clear vfs audit_cache before each run When generating a stream clone, we spend a large amount of time auditing path. Before this changes, the first run was warming the vfs cache for the other runs, leading to a large runtime difference and a "faulty" reported timing for the operation. We now clear this important cache between run to get a more realistic timing. Below are some example of median time change when clearing these cases. The maximum time for a run did not changed significantly. ### data-env-vars.name = mozilla-central-2018-08-01-zstd-sparse-revlog # benchmark.name = hg.perf.exchange.stream.generate # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.version = latest no-clearing: 17.289905 cache-clearing: 21.587965 (+24.86%, +4.30) ## data-env-vars.name = mozilla-central-2024-03-22-zstd-sparse-revlog no-clearing: 32.670748 cache-clearing: 40.467095 (+23.86%, +7.80) ## data-env-vars.name = mozilla-try-2019-02-18-zstd-sparse-revlog no-clearing: 37.838858 cache-clearing: 46.072749 (+21.76%, +8.23) ## data-env-vars.name = mozilla-unified-2024-03-22-zstd-sparse-revlog no-clearing: 32.969395 cache-clearing: 39.646209 (+20.25%, +6.68) In addition, this significantly reduce the timing difference between the performance command, from the perf extensions and a `real `hg bundle` call producing a stream bundle. Some significant differences remain especially on the "mozilla-try" repositories, but they are now smaller. Note that some of that difference will actually not be attributable to the stream generation (like maybe phases or branch map computation). Below are some benchmarks done on a currently draft changeset fixing some unrelated slowness in `hg bundle` (34a78972af409d1ff37c29e60f6ca811ad1a457d) ### data-env-vars.name = mozilla-central-2018-08-01-zstd-sparse-revlog # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default hg.perf.exchange.stream.generate: 21.587965 hg.command.bundle: 24.301799 (+12.57%, +2.71) ## data-env-vars.name = mozilla-central-2024-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 40.467095 hg.command.bundle: 44.831317 (+10.78%, +4.36) ## data-env-vars.name = mozilla-unified-2024-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 39.646209 hg.command.bundle: 45.395258 (+14.50%, +5.75) ## data-env-vars.name = mozilla-try-2019-02-18-zstd-sparse-revlog hg.perf.exchange.stream.generate: 46.072749 hg.command.bundle: 55.882608 (+21.29%, +9.81) ## data-env-vars.name = mozilla-try-2023-03-22-zlib-general-delta hg.perf.exchange.stream.generate: 334.716708 hg.command.bundle: 377.856767 (+12.89%, +43.14) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 302.972301 hg.command.bundle: 326.098755 (+7.63%, +23.13)

     1

#require svn svn-bindings

     2

     3

  $ cat >> $HGRCPATH <<EOF

     4

  > [extensions]

     5

  > convert =

     6

  > EOF

     7

  $ convert()

     8

  > {

     9

  >     startrev=$1

    10

  >     repopath=A-r$startrev-hg

    11

  >     hg convert --config convert.svn.startrev=$startrev \

    12

  >         --config convert.svn.trunk=branches/branch1 \

    13

  >         --config convert.svn.branches="  " \

    14

  >         --config convert.svn.tags= \

    15

  >         --datesort svn-repo $repopath

    16

  >     hg -R $repopath log -G \

    17

  >         --template '{rev} {desc|firstline} files: {files}\n'

    18

  >     echo

    19

  > }

    20

    21

  $ svnadmin create svn-repo

    22

  $ svnadmin load -q svn-repo < "$TESTDIR/svn/startrev.svndump"

    23

    24

Convert before branching point

    25

    26

  $ convert 3

    27

  initializing destination A-r3-hg repository

    28

  scanning source...

    29

  sorting...

    30

  converting...

    31

  3 removeb

    32

  2 changeaa

    33

  1 branch, changeaaa

    34

  0 addc,changeaaaa

    35

  o  3 addc,changeaaaa files: a c

    36

  |

    37

  o  2 branch, changeaaa files: a

    38

  |

    39

  o  1 changeaa files: a

    40

  |

    41

  o  0 removeb files: a

    42

    43

    44

    45

Convert before branching point

    46

    47

  $ convert 4

    48

  initializing destination A-r4-hg repository

    49

  scanning source...

    50

  sorting...

    51

  converting...

    52

  2 changeaa

    53

  1 branch, changeaaa

    54

  0 addc,changeaaaa

    55

  o  2 addc,changeaaaa files: a c

    56

  |

    57

  o  1 branch, changeaaa files: a

    58

  |

    59

  o  0 changeaa files: a

    60

    61

    62

    63

Convert at branching point

    64

    65

  $ convert 5

    66

  initializing destination A-r5-hg repository

    67

  scanning source...

    68

  sorting...

    69

  converting...

    70

  1 branch, changeaaa

    71

  0 addc,changeaaaa

    72

  o  1 addc,changeaaaa files: a c

    73

  |

    74

  o  0 branch, changeaaa files: a

    75

    76

    77

    78

Convert last revision only

    79

    80

  $ convert 6

    81

  initializing destination A-r6-hg repository

    82

  scanning source...

    83

  sorting...

    84

  converting...

    85

  0 addc,changeaaaa

    86

  o  0 addc,changeaaaa files: a c

    87

    88