perf: clear vfs audit_cache before each run When generating a stream clone, we spend a large amount of time auditing path. Before this changes, the first run was warming the vfs cache for the other runs, leading to a large runtime difference and a "faulty" reported timing for the operation. We now clear this important cache between run to get a more realistic timing. Below are some example of median time change when clearing these cases. The maximum time for a run did not changed significantly. ### data-env-vars.name = mozilla-central-2018-08-01-zstd-sparse-revlog # benchmark.name = hg.perf.exchange.stream.generate # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.version = latest no-clearing: 17.289905 cache-clearing: 21.587965 (+24.86%, +4.30) ## data-env-vars.name = mozilla-central-2024-03-22-zstd-sparse-revlog no-clearing: 32.670748 cache-clearing: 40.467095 (+23.86%, +7.80) ## data-env-vars.name = mozilla-try-2019-02-18-zstd-sparse-revlog no-clearing: 37.838858 cache-clearing: 46.072749 (+21.76%, +8.23) ## data-env-vars.name = mozilla-unified-2024-03-22-zstd-sparse-revlog no-clearing: 32.969395 cache-clearing: 39.646209 (+20.25%, +6.68) In addition, this significantly reduce the timing difference between the performance command, from the perf extensions and a `real `hg bundle` call producing a stream bundle. Some significant differences remain especially on the "mozilla-try" repositories, but they are now smaller. Note that some of that difference will actually not be attributable to the stream generation (like maybe phases or branch map computation). Below are some benchmarks done on a currently draft changeset fixing some unrelated slowness in `hg bundle` (34a78972af409d1ff37c29e60f6ca811ad1a457d) ### data-env-vars.name = mozilla-central-2018-08-01-zstd-sparse-revlog # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default hg.perf.exchange.stream.generate: 21.587965 hg.command.bundle: 24.301799 (+12.57%, +2.71) ## data-env-vars.name = mozilla-central-2024-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 40.467095 hg.command.bundle: 44.831317 (+10.78%, +4.36) ## data-env-vars.name = mozilla-unified-2024-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 39.646209 hg.command.bundle: 45.395258 (+14.50%, +5.75) ## data-env-vars.name = mozilla-try-2019-02-18-zstd-sparse-revlog hg.perf.exchange.stream.generate: 46.072749 hg.command.bundle: 55.882608 (+21.29%, +9.81) ## data-env-vars.name = mozilla-try-2023-03-22-zlib-general-delta hg.perf.exchange.stream.generate: 334.716708 hg.command.bundle: 377.856767 (+12.89%, +43.14) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 302.972301 hg.command.bundle: 326.098755 (+7.63%, +23.13)

     1

#!/bin/sh

     2

     3

# Script to get stable diff output on any platform.

     4

#

     5

# Output of this script is almost equivalent to GNU diff with "-Nru".

     6

#

     7

# Use this script as "hg pdiff" via extdiff extension with preparation

     8

# below in test scripts:

     9

#

    10

#   $ cat >> $HGRCPATH <<EOF

    11

#   > [extdiff]

    12

#   > pdiff = sh "$RUNTESTDIR/pdiff"

    13

#   > EOF

    14

    15

filediff(){

    16

    # USAGE: filediff file1 file2 [header]

    17

    18

    # compare with /dev/null if file doesn't exist (as "-N" option)

    19

    file1="$1"

    20

    if test ! -f "$file1"; then

    21

        file1=/dev/null

    22

    fi

    23

    file2="$2"

    24

    if test ! -f "$file2"; then

    25

        file2=/dev/null

    26

    fi

    27

    28

    if cmp -s "$file1" "$file2" 2> /dev/null; then

    29

        # Return immediately, because comparison isn't needed. This

    30

        # also avoids redundant message of diff like "No differences

    31

        # encountered" (on Solaris)

    32

        return

    33

    fi

    34

    35

    if test -n "$3"; then

    36

        # show header only in recursive case

    37

        echo "$3"

    38

    fi

    39

    40

    # replace "/dev/null" by corresponded filename (as "-N" option)

    41

    diff -u "$file1" "$file2" |

    42

    sed "s@^--- /dev/null\(.*\)\$@--- $1\1@" |

    43

    sed "s@^\+\+\+ /dev/null\(.*\)\$@+++ $2\1@"

    44

    45

    # in this case, files differ from each other

    46

    return 1

    47

}

    48

    49

if test -d "$1" -o -d "$2"; then

    50

    # ensure comparison in dictionary order

    51

    (

    52

    if test -d "$1"; then (cd "$1" && find . -type f); fi

    53

    if test -d "$2"; then (cd "$2" && find . -type f); fi

    54

    ) |

    55

    sed 's@^\./@@g' | sort | uniq |

    56

    while read file; do

    57

        filediff "$1/$file" "$2/$file" "diff -Nru $1/$file $2/$file"

    58

    done

    59

    60

    # TODO: there is no portable way for current while-read based

    61

    # implementation to return 1 at detecting changes.

    62

    #

    63

    # On bash and dash, assignment to variable inside while-block

    64

    # doesn't affect outside, because inside while-block is executed

    65

    # in sub-shell. BTW, it affects outside while-block on ksh (as sh

    66

    # on Solaris).

    67

else

    68

    filediff "$1" "$2"

    69

fi