.gitlab/merge_request_templates/Default.md
author Pierre-Yves David <pierre-yves.david@octobus.net>
Sat, 13 Apr 2024 23:40:28 +0200
changeset 51592 24844407fa0d
parent 49535 7b6d3a9bd7be
permissions -rw-r--r--
perf: clear vfs audit_cache before each run When generating a stream clone, we spend a large amount of time auditing path. Before this changes, the first run was warming the vfs cache for the other runs, leading to a large runtime difference and a "faulty" reported timing for the operation. We now clear this important cache between run to get a more realistic timing. Below are some example of median time change when clearing these cases. The maximum time for a run did not changed significantly. ### data-env-vars.name = mozilla-central-2018-08-01-zstd-sparse-revlog # benchmark.name = hg.perf.exchange.stream.generate # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.version = latest no-clearing: 17.289905 cache-clearing: 21.587965 (+24.86%, +4.30) ## data-env-vars.name = mozilla-central-2024-03-22-zstd-sparse-revlog no-clearing: 32.670748 cache-clearing: 40.467095 (+23.86%, +7.80) ## data-env-vars.name = mozilla-try-2019-02-18-zstd-sparse-revlog no-clearing: 37.838858 cache-clearing: 46.072749 (+21.76%, +8.23) ## data-env-vars.name = mozilla-unified-2024-03-22-zstd-sparse-revlog no-clearing: 32.969395 cache-clearing: 39.646209 (+20.25%, +6.68) In addition, this significantly reduce the timing difference between the performance command, from the perf extensions and a `real `hg bundle` call producing a stream bundle. Some significant differences remain especially on the "mozilla-try" repositories, but they are now smaller. Note that some of that difference will actually not be attributable to the stream generation (like maybe phases or branch map computation). Below are some benchmarks done on a currently draft changeset fixing some unrelated slowness in `hg bundle` (34a78972af409d1ff37c29e60f6ca811ad1a457d) ### data-env-vars.name = mozilla-central-2018-08-01-zstd-sparse-revlog # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default hg.perf.exchange.stream.generate: 21.587965 hg.command.bundle: 24.301799 (+12.57%, +2.71) ## data-env-vars.name = mozilla-central-2024-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 40.467095 hg.command.bundle: 44.831317 (+10.78%, +4.36) ## data-env-vars.name = mozilla-unified-2024-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 39.646209 hg.command.bundle: 45.395258 (+14.50%, +5.75) ## data-env-vars.name = mozilla-try-2019-02-18-zstd-sparse-revlog hg.perf.exchange.stream.generate: 46.072749 hg.command.bundle: 55.882608 (+21.29%, +9.81) ## data-env-vars.name = mozilla-try-2023-03-22-zlib-general-delta hg.perf.exchange.stream.generate: 334.716708 hg.command.bundle: 377.856767 (+12.89%, +43.14) ## data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog hg.perf.exchange.stream.generate: 302.972301 hg.command.bundle: 326.098755 (+7.63%, +23.13)
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
49216
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
     1
/assign_reviewer @mercurial.review
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
     2
49535
7b6d3a9bd7be mr-template: wrap the instructions inside a comment block
Matt Harbison <matt_harbison@yahoo.com>
parents: 49268
diff changeset
     3
7b6d3a9bd7be mr-template: wrap the instructions inside a comment block
Matt Harbison <matt_harbison@yahoo.com>
parents: 49268
diff changeset
     4
<!--
7b6d3a9bd7be mr-template: wrap the instructions inside a comment block
Matt Harbison <matt_harbison@yahoo.com>
parents: 49268
diff changeset
     5
49216
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
     6
Welcome to the Mercurial Merge Request creation process:
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
     7
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
     8
* Set a simple title for your MR,
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
     9
* All important information should be contained in your changesets' content or description,
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
    10
* You can add some workflow-relevant information here (eg: when this depends on another MR),
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
    11
* If your changes are not ready for review yet, click `Start the title with Draft:` under the title.
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
    12
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
    13
More details here:
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
    14
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
    15
* https://www.mercurial-scm.org/wiki/ContributingChanges
9ea9445c3223 workflow: add a default template for Merge Request
Pierre-Yves David <pierre-yves.david@octobus.net>
parents:
diff changeset
    16
* https://www.mercurial-scm.org/wiki/Heptapod
49535
7b6d3a9bd7be mr-template: wrap the instructions inside a comment block
Matt Harbison <matt_harbison@yahoo.com>
parents: 49268
diff changeset
    17
7b6d3a9bd7be mr-template: wrap the instructions inside a comment block
Matt Harbison <matt_harbison@yahoo.com>
parents: 49268
diff changeset
    18
-->