phases: rework the logic of _pushdiscoveryphase to bound complexity This rework the various graph traversal in _pushdiscoveryphase to keep the complexity in check. This is done though a couple of things: - first, limiting the space we have to explore, for example, if we are not in publishing push, we don't need to consider remote draft roots that are also draft locally, as there is nothing to be moved there. - avoid unbounded descendant computation, and use the faster "rev between" computation. This provide a massive boost to performance when exchanging with repository with a massive amount of draft, like mozilla-try: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 20.346590 seconds after: 11.232059 seconds (-38.15%, -7.48 seconds) ## benchmark.variants.revs = any-100-extra-rev before: 24.752051 seconds after: 15.367412 seconds (-37.91%, -9.38 seconds) After this changes, the push operation is still quite too slow. Some of this can be attributed to general phases slowness (reading all the roots from disk for example) and other know slowness (not using persistent-nodemap, branchmap, tags, etc. We are also working on them, but with this series, phase discovery during push no longer showing up in profile and this is a pretty nice and bit low-hanging fruit out of the way. ### (same case as the above) # benchmark.variants.revs = any-1-extra-rev pre-%ln-change: 44.235070 this-changeset: 11.232059 seconds (-74.61%, -33.00 seconds) # benchmark.variants.revs = any-100-extra-rev pre-%ln-change: 49.234697 this-changeset: 15.367412 seconds (-68.79%, -33.87 seconds) Note that with this change, the `hg push` performance is now much closer to the `hg pull` performance, even it still lagging behind a bit. (and the overall performance are still too slow). ### data-env-vars.name = mozilla-try-2023-03-22-ds2-pnm # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default # bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 6.517450 hg.command.push: 11.219888 ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 10.160991 hg.command.push: 14.251107 ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.577772 hg.command.push: 11.232059 ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.152976 hg.command.push: 15.367412 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.731982 hg.command.push: 11.178751 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.184236 hg.command.push: 15.620843

     1

#require no-symlink

     2

     3

# The following script was used to create the bundle:

     4

#

     5

# hg init symlinks

     6

# cd symlinks

     7

# echo a > a

     8

# mkdir d

     9

# echo b > d/b

    10

# ln -s a a.lnk

    11

# ln -s d/b d/b.lnk

    12

# hg ci -Am t

    13

# hg bundle --base null ../test-no-symlinks.hg

    14

    15

Extract a symlink on a platform not supporting them

    16

    17

  $ hg init t

    18

  $ cd t

    19

  $ hg pull -q "$TESTDIR/bundles/test-no-symlinks.hg"

    20

  $ hg update

    21

  4 files updated, 0 files merged, 0 files removed, 0 files unresolved

    22

  $ cat a.lnk && echo

    23

  a

    24

  $ cat d/b.lnk && echo

    25

  d/b

    26

    27

Copy a symlink and move another

    28

    29

  $ hg copy a.lnk d/a2.lnk

    30

  $ hg mv d/b.lnk b2.lnk

    31

  $ hg ci -Am copy

    32

  $ cat d/a2.lnk && echo

    33

  a

    34

  $ cat b2.lnk && echo

    35

  d/b

    36

    37

Bundle and extract again

    38

    39

  $ hg bundle --base null ../symlinks.hg

    40

  2 changesets found

    41

  $ cd ..

    42

  $ hg init t2

    43

  $ cd t2

    44

  $ hg pull ../symlinks.hg

    45

  pulling from ../symlinks.hg

    46

  requesting all changes

    47

  adding changesets

    48

  adding manifests

    49

  adding file changes

    50

  added 2 changesets with 6 changes to 6 files

    51

  new changesets d326ae2d01ee:71d85cf3ba90 (2 drafts)

    52

  (run 'hg update' to get a working copy)

    53

  $ hg update

    54

  5 files updated, 0 files merged, 0 files removed, 0 files unresolved

    55

  $ cat a.lnk && echo

    56

  a

    57

  $ cat d/a2.lnk && echo

    58

  a

    59

  $ cat b2.lnk && echo

    60

  d/b