phases: rework the logic of _pushdiscoveryphase to bound complexity This rework the various graph traversal in _pushdiscoveryphase to keep the complexity in check. This is done though a couple of things: - first, limiting the space we have to explore, for example, if we are not in publishing push, we don't need to consider remote draft roots that are also draft locally, as there is nothing to be moved there. - avoid unbounded descendant computation, and use the faster "rev between" computation. This provide a massive boost to performance when exchanging with repository with a massive amount of draft, like mozilla-try: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 20.346590 seconds after: 11.232059 seconds (-38.15%, -7.48 seconds) ## benchmark.variants.revs = any-100-extra-rev before: 24.752051 seconds after: 15.367412 seconds (-37.91%, -9.38 seconds) After this changes, the push operation is still quite too slow. Some of this can be attributed to general phases slowness (reading all the roots from disk for example) and other know slowness (not using persistent-nodemap, branchmap, tags, etc. We are also working on them, but with this series, phase discovery during push no longer showing up in profile and this is a pretty nice and bit low-hanging fruit out of the way. ### (same case as the above) # benchmark.variants.revs = any-1-extra-rev pre-%ln-change: 44.235070 this-changeset: 11.232059 seconds (-74.61%, -33.00 seconds) # benchmark.variants.revs = any-100-extra-rev pre-%ln-change: 49.234697 this-changeset: 15.367412 seconds (-68.79%, -33.87 seconds) Note that with this change, the `hg push` performance is now much closer to the `hg pull` performance, even it still lagging behind a bit. (and the overall performance are still too slow). ### data-env-vars.name = mozilla-try-2023-03-22-ds2-pnm # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default # bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 6.517450 hg.command.push: 11.219888 ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 10.160991 hg.command.push: 14.251107 ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.577772 hg.command.push: 11.232059 ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.152976 hg.command.push: 15.367412 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.731982 hg.command.push: 11.178751 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.184236 hg.command.push: 15.620843

     1

  $ hg init repo

     2

  $ cd repo

     3

     4

  $ echo "added file1" > file1

     5

  $ echo "added file2" > file2

     6

  $ hg add file1 file2

     7

  $ hg commit -m "added file1 and file2"

     8

     9

  $ echo "changed file1" >> file1

    10

  $ hg commit -m "changed file1"

    11

    12

  $ hg -q log

    13

  1:08a16e8e4408

    14

  0:d29c767a4b52

    15

  $ hg id

    16

  08a16e8e4408 tip

    17

    18

  $ hg update -C 0

    19

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    20

  $ hg id

    21

  d29c767a4b52

    22

  $ echo "changed file1" >> file1

    23

  $ hg id

    24

  d29c767a4b52+

    25

    26

  $ hg revert --all

    27

  reverting file1

    28

  $ hg diff

    29

  $ hg status

    30

  ? file1.orig

    31

  $ hg id

    32

  d29c767a4b52

    33

    34

  $ hg update

    35

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    36

  $ hg diff

    37

  $ hg status

    38

  ? file1.orig

    39

  $ hg id

    40

  08a16e8e4408 tip

    41

    42

  $ hg update -C 0

    43

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    44

  $ echo "changed file1" >> file1

    45

    46

  $ hg update

    47

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    48

  $ hg diff

    49

  $ hg status

    50

  ? file1.orig

    51

  $ hg id

    52

  08a16e8e4408 tip

    53

    54

  $ hg revert --all

    55

  $ hg diff

    56

  $ hg status

    57

  ? file1.orig

    58

  $ hg id

    59

  08a16e8e4408 tip

    60

    61

  $ hg revert -r tip --all

    62

  $ hg diff

    63

  $ hg status

    64

  ? file1.orig

    65

  $ hg id

    66

  08a16e8e4408 tip

    67

    68

  $ hg update -C

    69

  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

    70

  $ hg diff

    71

  $ hg status

    72

  ? file1.orig

    73

  $ hg id

    74

  08a16e8e4408 tip

    75