phases: rework the logic of _pushdiscoveryphase to bound complexity This rework the various graph traversal in _pushdiscoveryphase to keep the complexity in check. This is done though a couple of things: - first, limiting the space we have to explore, for example, if we are not in publishing push, we don't need to consider remote draft roots that are also draft locally, as there is nothing to be moved there. - avoid unbounded descendant computation, and use the faster "rev between" computation. This provide a massive boost to performance when exchanging with repository with a massive amount of draft, like mozilla-try: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 20.346590 seconds after: 11.232059 seconds (-38.15%, -7.48 seconds) ## benchmark.variants.revs = any-100-extra-rev before: 24.752051 seconds after: 15.367412 seconds (-37.91%, -9.38 seconds) After this changes, the push operation is still quite too slow. Some of this can be attributed to general phases slowness (reading all the roots from disk for example) and other know slowness (not using persistent-nodemap, branchmap, tags, etc. We are also working on them, but with this series, phase discovery during push no longer showing up in profile and this is a pretty nice and bit low-hanging fruit out of the way. ### (same case as the above) # benchmark.variants.revs = any-1-extra-rev pre-%ln-change: 44.235070 this-changeset: 11.232059 seconds (-74.61%, -33.00 seconds) # benchmark.variants.revs = any-100-extra-rev pre-%ln-change: 49.234697 this-changeset: 15.367412 seconds (-68.79%, -33.87 seconds) Note that with this change, the `hg push` performance is now much closer to the `hg pull` performance, even it still lagging behind a bit. (and the overall performance are still too slow). ### data-env-vars.name = mozilla-try-2023-03-22-ds2-pnm # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default # bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 6.517450 hg.command.push: 11.219888 ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 10.160991 hg.command.push: 14.251107 ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.577772 hg.command.push: 11.232059 ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.152976 hg.command.push: 15.367412 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.731982 hg.command.push: 11.178751 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.184236 hg.command.push: 15.620843

     1

Test hg log changeset printer external hook

     2

-------------------------------------------

     3

     4

  $ cat > $TESTTMP/logexthook.py <<EOF

     5

  > import codecs

     6

  > from mercurial import (

     7

  >   commands,

     8

  >   logcmdutil,

     9

  >   repair,

    10

  > )

    11

  > def brot13(b):

    12

  >     return codecs.encode(b.decode('utf8'), 'rot-13').encode('utf8')

    13

  > def rot13description(self, ctx):

    14

  >     description = ctx.description().strip().splitlines()[0]

    15

  >     self.ui.write(b"%s:     %s\n" % (brot13(b"summary"),

    16

  >                                      brot13(description)))

    17

  > def reposetup(ui, repo):

    18

  >     logcmdutil.changesetprinter._exthook = rot13description

    19

  > EOF

    20

    21

Prepare the repository

    22

    23

  $ hg init empty

    24

  $ cd empty

    25

  $ touch ROOT

    26

  $ hg commit -A -m "Root" ROOT

    27

    28

  $ touch a b c

    29

  $ hg commit -A -m "Add A, B, C" a b c

    30

    31

Check the log

    32

    33

  $ hg log --config extensions.t=$TESTTMP/logexthook.py

    34

  changeset:   1:70fc82b23320

    35

  tag:         tip

    36

  user:        test

    37

  date:        Thu Jan 01 00:00:00 1970 +0000

    38

  fhzznel:     Nqq N, O, P

    39

  summary:     Add A, B, C

    40

    41

  changeset:   0:b00443a54871

    42

  user:        test

    43

  date:        Thu Jan 01 00:00:00 1970 +0000

    44

  fhzznel:     Ebbg

    45

  summary:     Root

    46

    47

Check that exthook is working with graph log too

    48

    49

  $ hg log -G --config extensions.t=$TESTTMP/logexthook.py

    50

  @  changeset:   1:70fc82b23320

    51

  |  tag:         tip

    52

  |  user:        test

    53

  |  date:        Thu Jan 01 00:00:00 1970 +0000

    54

  |  fhzznel:     Nqq N, O, P

    55

  |  summary:     Add A, B, C

    56

  |

    57

  o  changeset:   0:b00443a54871

    58

     user:        test

    59

     date:        Thu Jan 01 00:00:00 1970 +0000

    60

     fhzznel:     Ebbg

    61

     summary:     Root

    62