phases: rework the logic of _pushdiscoveryphase to bound complexity This rework the various graph traversal in _pushdiscoveryphase to keep the complexity in check. This is done though a couple of things: - first, limiting the space we have to explore, for example, if we are not in publishing push, we don't need to consider remote draft roots that are also draft locally, as there is nothing to be moved there. - avoid unbounded descendant computation, and use the faster "rev between" computation. This provide a massive boost to performance when exchanging with repository with a massive amount of draft, like mozilla-try: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 20.346590 seconds after: 11.232059 seconds (-38.15%, -7.48 seconds) ## benchmark.variants.revs = any-100-extra-rev before: 24.752051 seconds after: 15.367412 seconds (-37.91%, -9.38 seconds) After this changes, the push operation is still quite too slow. Some of this can be attributed to general phases slowness (reading all the roots from disk for example) and other know slowness (not using persistent-nodemap, branchmap, tags, etc. We are also working on them, but with this series, phase discovery during push no longer showing up in profile and this is a pretty nice and bit low-hanging fruit out of the way. ### (same case as the above) # benchmark.variants.revs = any-1-extra-rev pre-%ln-change: 44.235070 this-changeset: 11.232059 seconds (-74.61%, -33.00 seconds) # benchmark.variants.revs = any-100-extra-rev pre-%ln-change: 49.234697 this-changeset: 15.367412 seconds (-68.79%, -33.87 seconds) Note that with this change, the `hg push` performance is now much closer to the `hg pull` performance, even it still lagging behind a bit. (and the overall performance are still too slow). ### data-env-vars.name = mozilla-try-2023-03-22-ds2-pnm # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default # bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 6.517450 hg.command.push: 11.219888 ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 10.160991 hg.command.push: 14.251107 ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.577772 hg.command.push: 11.232059 ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.152976 hg.command.push: 15.367412 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.731982 hg.command.push: 11.178751 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.184236 hg.command.push: 15.620843

     1

import os

     2

from mercurial.hgweb import hgwebdir_mod

     3

     4

hgwebdir = hgwebdir_mod.hgwebdir

     5

     6

os.mkdir(b'webdir')

     7

os.chdir(b'webdir')

     8

     9

webdir = os.path.realpath(b'.')

    10

    11

    12

def trivial_response(req, res):

    13

    return []

    14

    15

    16

def make_hgwebdir(gc_rate=None):

    17

    config = os.path.join(webdir, b'hgwebdir.conf')

    18

    with open(config, 'wb') as configfile:

    19

        configfile.write(b'[experimental]\n')

    20

        if gc_rate is not None:

    21

            configfile.write(b'web.full-garbage-collection-rate=%d\n' % gc_rate)

    22

    hg_wd = hgwebdir(config)

    23

    hg_wd._runwsgi = trivial_response

    24

    return hg_wd

    25

    26

    27

def process_requests(webdir_instance, number):

    28

    # we don't care for now about passing realistic arguments

    29

    for _ in range(number):

    30

        for chunk in webdir_instance.run_wsgi(None, None):

    31

            pass

    32

    33

    34

without_gc = make_hgwebdir(gc_rate=0)

    35

process_requests(without_gc, 5)

    36

assert without_gc.requests_count == 5

    37

assert without_gc.gc_full_collections_done == 0

    38

    39

with_gc = make_hgwebdir(gc_rate=2)

    40

process_requests(with_gc, 5)

    41

assert with_gc.requests_count == 5

    42

assert with_gc.gc_full_collections_done == 2

    43

    44

with_systematic_gc = make_hgwebdir()  # default value of the setting

    45

process_requests(with_systematic_gc, 3)

    46

assert with_systematic_gc.requests_count == 3

    47

assert with_systematic_gc.gc_full_collections_done == 3