phases: rework the logic of _pushdiscoveryphase to bound complexity This rework the various graph traversal in _pushdiscoveryphase to keep the complexity in check. This is done though a couple of things: - first, limiting the space we have to explore, for example, if we are not in publishing push, we don't need to consider remote draft roots that are also draft locally, as there is nothing to be moved there. - avoid unbounded descendant computation, and use the faster "rev between" computation. This provide a massive boost to performance when exchanging with repository with a massive amount of draft, like mozilla-try: ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # benchmark.name = hg.command.push # bin-env-vars.hg.flavor = default # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.reuse-external-delta-parent = default ## benchmark.variants.revs = any-1-extra-rev before: 20.346590 seconds after: 11.232059 seconds (-38.15%, -7.48 seconds) ## benchmark.variants.revs = any-100-extra-rev before: 24.752051 seconds after: 15.367412 seconds (-37.91%, -9.38 seconds) After this changes, the push operation is still quite too slow. Some of this can be attributed to general phases slowness (reading all the roots from disk for example) and other know slowness (not using persistent-nodemap, branchmap, tags, etc. We are also working on them, but with this series, phase discovery during push no longer showing up in profile and this is a pretty nice and bit low-hanging fruit out of the way. ### (same case as the above) # benchmark.variants.revs = any-1-extra-rev pre-%ln-change: 44.235070 this-changeset: 11.232059 seconds (-74.61%, -33.00 seconds) # benchmark.variants.revs = any-100-extra-rev pre-%ln-change: 49.234697 this-changeset: 15.367412 seconds (-68.79%, -33.87 seconds) Note that with this change, the `hg push` performance is now much closer to the `hg pull` performance, even it still lagging behind a bit. (and the overall performance are still too slow). ### data-env-vars.name = mozilla-try-2023-03-22-ds2-pnm # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default # bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 6.517450 hg.command.push: 11.219888 ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 10.160991 hg.command.push: 14.251107 ### data-env-vars.name = mozilla-try-2023-03-22-zstd-sparse-revlog # bin-env-vars.hg.py-re2-module = default # benchmark.variants.explicit-rev = all-out-heads # benchmark.variants.issue6528 = disabled # benchmark.variants.protocol = ssh # benchmark.variants.pulled-delta-reuse-policy = default ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.577772 hg.command.push: 11.232059 ## bin-env-vars.hg.flavor = default ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.152976 hg.command.push: 15.367412 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-1-extra-rev hg.command.pull: 8.731982 hg.command.push: 11.178751 ## bin-env-vars.hg.flavor = rust ## benchmark.variants.revs = any-100-extra-rev hg.command.pull: 13.184236 hg.command.push: 15.620843

     1

Force revlog max inline value to be smaller than default

     2

     3

  $ mkdir $TESTTMP/ext

     4

  $ cat << EOF > $TESTTMP/ext/small_inline.py

     5

  > from mercurial import revlog

     6

  > revlog._maxinline = 8

     7

  > EOF

     8

     9

  $ cat << EOF >> $HGRCPATH

    10

  > [extensions]

    11

  > small_inline=$TESTTMP/ext/small_inline.py

    12

  > EOF

    13

    14

  $ hg init repo

    15

  $ cd repo

    16

    17

Try on an empty repository

    18

    19

  $ hg debug-revlog-stats

    20

  rev-count   data-size inl type      target 

    21

    22

  $ mkdir folder

    23

  $ touch a b folder/c folder/d

    24

  $ hg commit -Aqm 0

    25

  $ echo "text" > a

    26

  $ hg rm b

    27

  $ echo "longer string" > folder/d

    28

  $ hg commit -Aqm 1

    29

    30

Differences in data size observed with pure is due to different compression

    31

algorithms

    32

    33

  $ hg debug-revlog-stats

    34

  rev-count   data-size inl type      target 

    35

          2         138 no  changelog  (no-pure !)

    36

          2         137 no  changelog  (pure !)

    37

          2         177 no  manifest   (no-pure !)

    38

          2         168 no  manifest   (pure !)

    39

          2           6 yes file      a

    40

          1           0 yes file      b

    41

          1           0 yes file      folder/c

    42

          2          15 no  file      folder/d

    43

    44

Test 'changelog' command argument

    45

    46

  $ hg debug-revlog-stats -c

    47

  rev-count   data-size inl type      target 

    48

          2         138 no  changelog  (no-pure !)

    49

          2         137 no  changelog  (pure !)

    50

    51

Test 'manifest' command argument

    52

    53

  $ hg debug-revlog-stats -m

    54

  rev-count   data-size inl type      target 

    55

          2         177 no  manifest   (no-pure !)

    56

          2         168 no  manifest   (pure !)

    57

    58

Test 'file' command argument

    59

    60

  $ hg debug-revlog-stats -f

    61

  rev-count   data-size inl type      target 

    62

          2           6 yes file      a

    63

          1           0 yes file      b

    64

          1           0 yes file      folder/c

    65

          2          15 no  file      folder/d

    66

    67

Test multiple command arguments

    68

    69

  $ hg debug-revlog-stats -cm

    70

  rev-count   data-size inl type      target 

    71

          2         138 no  changelog  (no-pure !)

    72

          2         137 no  changelog  (pure !)

    73

          2         177 no  manifest   (no-pure !)

    74

          2         168 no  manifest   (pure !)

    75