hgweb: fix trust of templates path (BC) Long ago we disabled trust of the templates path with a comment describing the (insecure) behavior before the change. At some later refactor, the code was apparently changed back to match the comment, unaware that the intent of the comment was to describe the behavior to avoid. This change disables the trust and updates the comment to explicitly say not only what the old problem was, but also that it was in fact a problem and the action taken to prevent it. Impact: prior to this change, if you had a UNIX-based hgweb server where users can write hgrc files, those users could potentially read any file readable by the web server. This is marked as a backwards compatibility issue because people may have configured templates without proper trust settings. Issue spotted by Greg Szorc.

     1

import os

     2

from mercurial import dispatch

     3

     4

def testdispatch(cmd):

     5

    """Simple wrapper around dispatch.dispatch()

     6

     7

    Prints command and result value, but does not handle quoting.

     8

    """

     9

    print "running: %s" % (cmd,)

    10

    req = dispatch.request(cmd.split())

    11

    result = dispatch.dispatch(req)

    12

    print "result: %r" % (result,)

    13

    14

    15

testdispatch("init test1")

    16

os.chdir('test1')

    17

    18

# create file 'foo', add and commit

    19

f = open('foo', 'wb')

    20

f.write('foo\n')

    21

f.close()

    22

testdispatch("add foo")

    23

testdispatch("commit -m commit1 -d 2000-01-01 foo")

    24

    25

# append to file 'foo' and commit

    26

f = open('foo', 'ab')

    27

f.write('bar\n')

    28

f.close()

    29

testdispatch("commit -m commit2 -d 2000-01-02 foo")

    30

    31

# check 88803a69b24 (fancyopts modified command table)

    32

testdispatch("log -r 0")

    33

testdispatch("log -r tip")