annotate: increase refcount of each revisions correctly (issue3841) Before this patch, refcount (managed in "needed") of parents of each revisions in "visit" is increased, only when parent is not annotated yet (examined by "p not in hist"). But this causes less refcount of the revision like "A" in the tree below ("A" is assumed as the second parent of "C"): A --- B --- C \ / \-----/ Steps of annotation for "C" in this case are shown below: 1. for "C" 1.1 increase refcount of "B" 1.2 increase refcount of "A" (=> 1) 1.3 defer annotation for "C" 2. for "A" 2.1 annotate for "A" (=> put result into "hist[A]") 2.2 clear "pcache[A]" ("pcache[A] = []") 3. for "B" 3.1 not increase refcount of "A", because "A not in hist" is False 3.2 annotate for "B" 3.3 decrease refcount of "A" (=> 0) 3.4 delete "hist[A]", even though "A" is still needed by "C" 3.5 clear "pcache[B]" 4. for "C", again 4.1 not increase refcount of "B", because "B not in hist" is False 4.2 increase refcount of "A" (=> 1) 4.3 defer annotation for "C" 5. for "A", again 5.1 annotate for "A" (=> put result into "hist[A]", again) 5.2 clear "pcache[A]" 6. for "C", once again 6.1 not increase refcount of "B", because "B not in hist" is False 6.2 not increase refcount of "A", because "A not in hist" is False 6.3 annotate for "C" 6.4 decrease refcount of "A", and delete "hist[A]" 6.5 decrease refcount of "B", and delete "hist[B]" 6.6 clear "pcache[C]" At step (5.1), annotation for "A" mis-recognizes that all lines are created at "A", because "pcache[A]" already cleared at step (2.2) prevents from scanning ancestors of "A". So, annotation for "C" or its descendants loses information about "A" or its ancestors. The root cause of this problem is that refcount of "A" is decreased at step (3.3), even though it isn't increased at step (3.1). To increase refcount correctly, this patch increases refcount of each parents of each revisions: - regardless of "p not in hist" or not, and - only once for each revisions in "visit" (by "not pcached") In fact, this problem should occur only on legacy repositories in which a filelog includes the merging between the revision and its ancestor (as the second parent), because: - tree is scanned in depth-first without such merging, revisions in "visit" refer different revisions as parent each other - recent Mercurial doesn't allow such merging changelog and manifest can include such merging someway, but filelogs can't, because "localrepository._filecommit()" converts such merging request to linear history. This patch tests merging cases below: these cases are from filelog of "mercurial/commands.py" in the repository of Mercurial itself. - both parents are same 10 --- 11 --- 12 \_/ filelogrev: changesetid: 10 00ea3613f82c 11 fc4a6e5b5812 12 4f802588cdfb - the second parent is also ancestor of the first one 37 --- 38 --- 39 --- 40 \________/ filelogrev: changesetid: 37 f8d56da6ac8f 38 38919e1c254d 39 d3400605d246 40 f06a4a3b86a7

     1

from mercurial.dicthelpers import diff, join

     2

import unittest

     3

import silenttestrunner

     4

     5

class testdicthelpers(unittest.TestCase):

     6

    def test_dicthelpers(self):

     7

        # empty dicts

     8

        self.assertEqual(diff({}, {}), {})

     9

        self.assertEqual(join({}, {}), {})

    10

    11

        d1 = {}

    12

        d1['a'] = 'foo'

    13

        d1['b'] = 'bar'

    14

        d1['c'] = 'baz'

    15

    16

        # same identity

    17

        self.assertEqual(diff(d1, d1), {})

    18

        self.assertEqual(join(d1, d1), {'a': ('foo', 'foo'),

    19

                                        'b': ('bar', 'bar'),

    20

                                        'c': ('baz', 'baz')})

    21

    22

        # vs empty

    23

        self.assertEqual(diff(d1, {}), {'a': ('foo', None),

    24

                                        'b': ('bar', None),

    25

                                        'c': ('baz', None)})

    26

        self.assertEqual(diff(d1, {}), {'a': ('foo', None),

    27

                                        'b': ('bar', None),

    28

                                        'c': ('baz', None)})

    29

    30

        d2 = {}

    31

        d2['a'] = 'foo2'

    32

        d2['b'] = 'bar'

    33

        d2['d'] = 'quux'

    34

    35

        self.assertEqual(diff(d1, d2), {'a': ('foo', 'foo2'),

    36

                                        'c': ('baz', None),

    37

                                        'd': (None, 'quux')})

    38

        self.assertEqual(join(d1, d2), {'a': ('foo', 'foo2'),

    39

                                        'b': ('bar', 'bar'),

    40

                                        'c': ('baz', None),

    41

                                        'd': (None, 'quux')})

    42

    43

        # with default argument

    44

        self.assertEqual(diff(d1, d2, 123), {'a': ('foo', 'foo2'),

    45

                                             'c': ('baz', 123),

    46

                                             'd': (123, 'quux')})

    47

        self.assertEqual(join(d1, d2, 456), {'a': ('foo', 'foo2'),

    48

                                             'b': ('bar', 'bar'),

    49

                                             'c': ('baz', 456),

    50

                                             'd': (456, 'quux')})

    51

    52

        # check that we compare against default

    53

        self.assertEqual(diff(d1, d2, 'baz'), {'a': ('foo', 'foo2'),

    54

                                               'd': ('baz', 'quux')})

    55

        self.assertEqual(diff(d1, d2, 'quux'), {'a': ('foo', 'foo2'),

    56

                                                'c': ('baz', 'quux')})

    57

    58

if __name__ == '__main__':

    59

    silenttestrunner.main(__name__)