manifest: persist the manifestfulltext cache Reconstructing the manifest from the revlog takes time, so much so that there already is a LRU cache to avoid having to load a manifest multiple times. This patch persists that LRU cache in the .hg/cache directory, so we can re-use this cache across hg commands. Commit benchmark (run on Macos 10.13 on a 2017-model Macbook Pro with Core i7 2.9GHz and flash drive), testing without and with patch run 5 times, baseline is r2a227782e754: * committing to an existing file, against the mozilla-central repository. Baseline real time average 1.9692, with patch 1.3786. A new debugcommand "hg debugmanifestfulltextcache" lets you inspect the cache, clear it, or add specific manifest nodeids to it. When calling repo.updatecaches(), the manifest(s) for the working copy parents are added to the cache. The hg perfmanifest command has an additional --clear-disk switch to clear this cache when testing manifest loading performance. Using this command to test performance on the firefox repository for revision f947d902ed91, whose manifest has a delta chain length of 60540, we see: $ hg perfmanifest f947d902ed91 --clear-disk ! wall 0.972253 comb 0.970000 user 0.850000 sys 0.120000 (best of 10) $ hg debugmanifestfulltextcache -a `hg log --debug -r f947d902ed91 | grep manifest | cut -d: -f3` Cache contains 1 manifest entries, in order of most to least recent: id: 0294517df4aad07c70701db43bc7ff24c3ce7dbc, size 25.6 MB Total cache data size 25.6 MB, on-disk 0 bytes $ hg perfmanifest f947d902ed91 ! wall 0.036748 comb 0.040000 user 0.020000 sys 0.020000 (best of 100) Worst-case scenario: a manifest text loaded from a single delta; in the firefox repository manifest node 9a1246ff762e is the chain base for the manifest attached to revision f947d902ed91. Loading this from a full cache file is just as fast as without the cache; the extra node ids ensure a big full cache: $ for node in 9a1246ff762e 1a1922c14a3e 54a31d11a36a 0294517df4aa; do > hgd debugmanifestfulltextcache -a $node > /dev/null > done $ hgd perfmanifest -m 9a1246ff762e ! wall 0.077513 comb 0.080000 user 0.030000 sys 0.050000 (best of 100) $ hgd perfmanifest -m 9a1246ff762e --clear-disk ! wall 0.078547 comb 0.080000 user 0.070000 sys 0.010000 (best of 100)

     1

from __future__ import absolute_import, print_function

     2

     3

from mercurial import extensions

     4

     5

def genwrapper(x):

     6

    def f(orig, *args, **kwds):

     7

        return [x] + orig(*args, **kwds)

     8

    f.x = x

     9

    return f

    10

    11

def getid(wrapper):

    12

    return getattr(wrapper, 'x', '-')

    13

    14

wrappers = [genwrapper(i) for i in range(5)]

    15

    16

class dummyclass(object):

    17

    def getstack(self):

    18

        return ['orig']

    19

    20

dummy = dummyclass()

    21

    22

def batchwrap(wrappers):

    23

    for w in wrappers:

    24

        extensions.wrapfunction(dummy, 'getstack', w)

    25

        print('wrap %d: %s' % (getid(w), dummy.getstack()))

    26

    27

def batchunwrap(wrappers):

    28

    for w in wrappers:

    29

        result = None

    30

        try:

    31

            result = extensions.unwrapfunction(dummy, 'getstack', w)

    32

            msg = str(dummy.getstack())

    33

        except (ValueError, IndexError) as e:

    34

            msg = e.__class__.__name__

    35

        print('unwrap %s: %s: %s' % (getid(w), getid(result), msg))

    36

    37

batchwrap(wrappers + [wrappers[0]])

    38

batchunwrap([(wrappers[i] if i is not None and i >= 0 else None)

    39

             for i in [3, None, 0, 4, 0, 2, 1, None]])

    40

    41

wrap0 = extensions.wrappedfunction(dummy, 'getstack', wrappers[0])

    42

wrap1 = extensions.wrappedfunction(dummy, 'getstack', wrappers[1])

    43

    44

# Use them in a different order from how they were created to check that

    45

# the wrapping happens in __enter__, not in __init__

    46

print('context manager', dummy.getstack())

    47

with wrap1:

    48

    print('context manager', dummy.getstack())

    49

    with wrap0:

    50

        print('context manager', dummy.getstack())

    51

        # Bad programmer forgets to unwrap the function, but the context

    52

        # managers still unwrap their wrappings.

    53

        extensions.wrapfunction(dummy, 'getstack', wrappers[2])

    54

        print('context manager', dummy.getstack())

    55

    print('context manager', dummy.getstack())

    56

print('context manager', dummy.getstack())

    57

    58

# Wrap callable object which has no __name__

    59

class callableobj(object):

    60

    def __call__(self):

    61

        return ['orig']

    62

dummy.cobj = callableobj()

    63

extensions.wrapfunction(dummy, 'cobj', wrappers[0])

    64

print('wrap callable object', dummy.cobj())