manifest: persist the manifestfulltext cache Reconstructing the manifest from the revlog takes time, so much so that there already is a LRU cache to avoid having to load a manifest multiple times. This patch persists that LRU cache in the .hg/cache directory, so we can re-use this cache across hg commands. Commit benchmark (run on Macos 10.13 on a 2017-model Macbook Pro with Core i7 2.9GHz and flash drive), testing without and with patch run 5 times, baseline is r2a227782e754: * committing to an existing file, against the mozilla-central repository. Baseline real time average 1.9692, with patch 1.3786. A new debugcommand "hg debugmanifestfulltextcache" lets you inspect the cache, clear it, or add specific manifest nodeids to it. When calling repo.updatecaches(), the manifest(s) for the working copy parents are added to the cache. The hg perfmanifest command has an additional --clear-disk switch to clear this cache when testing manifest loading performance. Using this command to test performance on the firefox repository for revision f947d902ed91, whose manifest has a delta chain length of 60540, we see: $ hg perfmanifest f947d902ed91 --clear-disk ! wall 0.972253 comb 0.970000 user 0.850000 sys 0.120000 (best of 10) $ hg debugmanifestfulltextcache -a `hg log --debug -r f947d902ed91 | grep manifest | cut -d: -f3` Cache contains 1 manifest entries, in order of most to least recent: id: 0294517df4aad07c70701db43bc7ff24c3ce7dbc, size 25.6 MB Total cache data size 25.6 MB, on-disk 0 bytes $ hg perfmanifest f947d902ed91 ! wall 0.036748 comb 0.040000 user 0.020000 sys 0.020000 (best of 100) Worst-case scenario: a manifest text loaded from a single delta; in the firefox repository manifest node 9a1246ff762e is the chain base for the manifest attached to revision f947d902ed91. Loading this from a full cache file is just as fast as without the cache; the extra node ids ensure a big full cache: $ for node in 9a1246ff762e 1a1922c14a3e 54a31d11a36a 0294517df4aa; do > hgd debugmanifestfulltextcache -a $node > /dev/null > done $ hgd perfmanifest -m 9a1246ff762e ! wall 0.077513 comb 0.080000 user 0.030000 sys 0.050000 (best of 100) $ hgd perfmanifest -m 9a1246ff762e --clear-disk ! wall 0.078547 comb 0.080000 user 0.070000 sys 0.010000 (best of 100)

     1

#require test-repo

     2

     3

  $ . "$TESTDIR/helpers-testrepo.sh"

     4

     5

Sanity check check-config.py

     6

     7

  $ cat > testfile.py << EOF

     8

  > # Good

     9

  > foo = ui.config('ui', 'username')

    10

  > # Missing

    11

  > foo = ui.config('ui', 'doesnotexist')

    12

  > # Missing different type

    13

  > foo = ui.configint('ui', 'missingint')

    14

  > # Missing with default value

    15

  > foo = ui.configbool('ui', 'missingbool1', default=True)

    16

  > foo = ui.configbool('ui', 'missingbool2', False)

    17

  > # Inconsistent values for defaults.

    18

  > foo = ui.configint('ui', 'intdefault', default=1)

    19

  > foo = ui.configint('ui', 'intdefault', default=42)

    20

  > # Can suppress inconsistent value error

    21

  > foo = ui.configint('ui', 'intdefault2', default=1)

    22

  > # inconsistent config: ui.intdefault2

    23

  > foo = ui.configint('ui', 'intdefault2', default=42)

    24

  > EOF

    25

    26

  $ cat > files << EOF

    27

  > mercurial/help/config.txt

    28

  > $TESTTMP/testfile.py

    29

  > EOF

    30

    31

  $ cd "$TESTDIR"/..

    32

    33

  $ $PYTHON contrib/check-config.py < $TESTTMP/files

    34

  foo = ui.configint('ui', 'intdefault', default=42)

    35

  conflict on ui.intdefault: ('int', '42') != ('int', '1')

    36

  at $TESTTMP/testfile.py:12:

    37

  undocumented: ui.doesnotexist (str)

    38

  undocumented: ui.intdefault (int) [42]

    39

  undocumented: ui.intdefault2 (int) [42]

    40

  undocumented: ui.missingbool1 (bool) [True]

    41

  undocumented: ui.missingbool2 (bool)

    42

  undocumented: ui.missingint (int)

    43

    44

New errors are not allowed. Warnings are strongly discouraged.

    45

    46

  $ testrepohg files "set:(**.py or **.txt) - tests/**" | sed 's|\\|/|g' |

    47

  >   $PYTHON contrib/check-config.py