tests/test-remotefilelog-hgweb.t
author Manuel Jacob <me@manueljacob.de>
Mon, 11 Jul 2022 01:51:20 +0200
branchstable
changeset 49378 094a5fa3cf52
parent 44570 9e63108123a4
permissions -rw-r--r--
procutil: make stream detection in make_line_buffered more correct and strict In make_line_buffered(), we don’t want to wrap the stream if we know that lines get flushed to the underlying raw stream already. Previously, the heuristic was too optimistic. It assumed that any stream which is not an instance of io.BufferedIOBase doesn’t need wrapping. However, there are buffered streams that aren’t instances of io.BufferedIOBase, like Mercurial’s own winstdout. The new logic is different in two ways: First, only for the check, if unwraps any combination of WriteAllWrapper and winstdout. Second, it skips wrapping the stream only if it is an instance of io.RawIOBase (or already wrapped). If it is an instance of io.BufferedIOBase, it gets wrapped. In any other case, the function raises an exception. This ensures that, if an unknown stream is passed or we add another wrapper in the future, we don’t wrap the stream if it’s already line buffered or not wrap the stream if it’s not line buffered. In fact, this was already helpful during development of this change. Without it, I possibly would have forgot that WriteAllWrapper needs to be ignored for the check, leading to unnecessary wrapping if stdout is unbuffered. The alternative would have been to always wrap unknown streams. However, I don’t think that anyone would benefit from being less strict. We can expect streams from the standard library to be subclassing either io.RawIOBase or io.BufferedIOBase, so running Mercurial in the standard way should not regress by this change. Py2exe might replace sys.stdout and sys.stderr, but that currently breaks Mercurial anyway and also these streams don’t claim to be interactive, so this function is not called for them.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
44569
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
     1
#require no-windows serve
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
     2
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
     3
  $ . "$TESTDIR/remotefilelog-library.sh"
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
     4
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
     5
  $ cat >> $HGRCPATH <<EOF
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
     6
  > [extensions]
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
     7
  > remotefilelog=
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
     8
  > share=
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
     9
  > EOF
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    10
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    11
  $ hg init master
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    12
  $ cd master
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    13
  $ cat >> .hg/hgrc <<EOF
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    14
  > [remotefilelog]
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    15
  > server=True
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    16
  > EOF
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    17
  $ echo x > x
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    18
  $ hg commit -qAm x
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    19
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    20
  $ cd ..
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    21
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    22
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    23
  $ hgcloneshallow ssh://user@dummy/master wdir --noupdate -q
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    24
  $ cd wdir
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    25
  $ hg serve -n test -p $HGPORT -d --pid-file=hg.pid -E errors.log
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    26
  $ cat hg.pid >> $DAEMON_PIDS
44570
9e63108123a4 remotefilelog: add fake heads() method that allows viewing a file in hgweb
Augie Fackler <augie@google.com>
parents: 44569
diff changeset
    27
  $ get-with-headers.py localhost:$HGPORT 'file/tip/x' | head -n 10
9e63108123a4 remotefilelog: add fake heads() method that allows viewing a file in hgweb
Augie Fackler <augie@google.com>
parents: 44569
diff changeset
    28
  200 Script output follows
44569
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    29
  
44570
9e63108123a4 remotefilelog: add fake heads() method that allows viewing a file in hgweb
Augie Fackler <augie@google.com>
parents: 44569
diff changeset
    30
  <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
9e63108123a4 remotefilelog: add fake heads() method that allows viewing a file in hgweb
Augie Fackler <augie@google.com>
parents: 44569
diff changeset
    31
  <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-US">
9e63108123a4 remotefilelog: add fake heads() method that allows viewing a file in hgweb
Augie Fackler <augie@google.com>
parents: 44569
diff changeset
    32
  <head>
9e63108123a4 remotefilelog: add fake heads() method that allows viewing a file in hgweb
Augie Fackler <augie@google.com>
parents: 44569
diff changeset
    33
  <link rel="icon" href="/static/hgicon.png" type="image/png" />
9e63108123a4 remotefilelog: add fake heads() method that allows viewing a file in hgweb
Augie Fackler <augie@google.com>
parents: 44569
diff changeset
    34
  <meta name="robots" content="index, nofollow" />
9e63108123a4 remotefilelog: add fake heads() method that allows viewing a file in hgweb
Augie Fackler <augie@google.com>
parents: 44569
diff changeset
    35
  <link rel="stylesheet" href="/static/style-paper.css" type="text/css" />
9e63108123a4 remotefilelog: add fake heads() method that allows viewing a file in hgweb
Augie Fackler <augie@google.com>
parents: 44569
diff changeset
    36
  <script type="text/javascript" src="/static/mercurial.js"></script>
9e63108123a4 remotefilelog: add fake heads() method that allows viewing a file in hgweb
Augie Fackler <augie@google.com>
parents: 44569
diff changeset
    37
  
44569
5483e9c759e4 tests: add test for remotefilelog interactions with hgweb
Augie Fackler <augie@google.com>
parents:
diff changeset
    38