procutil: make stream detection in make_line_buffered more correct and strict In make_line_buffered(), we don’t want to wrap the stream if we know that lines get flushed to the underlying raw stream already. Previously, the heuristic was too optimistic. It assumed that any stream which is not an instance of io.BufferedIOBase doesn’t need wrapping. However, there are buffered streams that aren’t instances of io.BufferedIOBase, like Mercurial’s own winstdout. The new logic is different in two ways: First, only for the check, if unwraps any combination of WriteAllWrapper and winstdout. Second, it skips wrapping the stream only if it is an instance of io.RawIOBase (or already wrapped). If it is an instance of io.BufferedIOBase, it gets wrapped. In any other case, the function raises an exception. This ensures that, if an unknown stream is passed or we add another wrapper in the future, we don’t wrap the stream if it’s already line buffered or not wrap the stream if it’s not line buffered. In fact, this was already helpful during development of this change. Without it, I possibly would have forgot that WriteAllWrapper needs to be ignored for the check, leading to unnecessary wrapping if stdout is unbuffered. The alternative would have been to always wrap unknown streams. However, I don’t think that anyone would benefit from being less strict. We can expect streams from the standard library to be subclassing either io.RawIOBase or io.BufferedIOBase, so running Mercurial in the standard way should not regress by this change. Py2exe might replace sys.stdout and sys.stderr, but that currently breaks Mercurial anyway and also these streams don’t claim to be interactive, so this function is not called for them.

     1

= Test the known() protocol function =

     2

     3

Create a test repository:

     4

     5

  $ hg init repo

     6

  $ cd repo

     7

  $ touch a ; hg add a ; hg ci -ma

     8

  $ touch b ; hg add b ; hg ci -mb

     9

  $ touch c ; hg add c ; hg ci -mc

    10

  $ hg log --template '{node}\n'

    11

  991a3460af53952d10ec8a295d3d2cc2e5fa9690

    12

  0e067c57feba1a5694ca4844f05588bb1bf82342

    13

  3903775176ed42b1458a6281db4a0ccf4d9f287a

    14

  $ cd ..

    15

    16

Test locally:

    17

    18

  $ hg debugknown repo 991a3460af53952d10ec8a295d3d2cc2e5fa9690 0e067c57feba1a5694ca4844f05588bb1bf82342 3903775176ed42b1458a6281db4a0ccf4d9f287a

    19

  111

    20

  $ hg debugknown repo 000a3460af53952d10ec8a295d3d2cc2e5fa9690 0e067c57feba1a5694ca4844f05588bb1bf82342 0003775176ed42b1458a6281db4a0ccf4d9f287a

    21

  010

    22

  $ hg debugknown repo

    23

    24

    25

Test via HTTP:

    26

    27

  $ hg serve -R repo -p $HGPORT -d --pid-file=hg.pid -E error.log -A access.log

    28

  $ cat hg.pid >> $DAEMON_PIDS

    29

  $ hg debugknown http://localhost:$HGPORT/ 991a3460af53952d10ec8a295d3d2cc2e5fa9690 0e067c57feba1a5694ca4844f05588bb1bf82342 3903775176ed42b1458a6281db4a0ccf4d9f287a

    30

  111

    31

  $ hg debugknown http://localhost:$HGPORT/ 000a3460af53952d10ec8a295d3d2cc2e5fa9690 0e067c57feba1a5694ca4844f05588bb1bf82342 0003775176ed42b1458a6281db4a0ccf4d9f287a

    32

  010

    33

  $ hg debugknown http://localhost:$HGPORT/

    34

    35

  $ cat error.log

    36

  $ killdaemons.py

    37