procutil: make stream detection in make_line_buffered more correct and strict In make_line_buffered(), we don’t want to wrap the stream if we know that lines get flushed to the underlying raw stream already. Previously, the heuristic was too optimistic. It assumed that any stream which is not an instance of io.BufferedIOBase doesn’t need wrapping. However, there are buffered streams that aren’t instances of io.BufferedIOBase, like Mercurial’s own winstdout. The new logic is different in two ways: First, only for the check, if unwraps any combination of WriteAllWrapper and winstdout. Second, it skips wrapping the stream only if it is an instance of io.RawIOBase (or already wrapped). If it is an instance of io.BufferedIOBase, it gets wrapped. In any other case, the function raises an exception. This ensures that, if an unknown stream is passed or we add another wrapper in the future, we don’t wrap the stream if it’s already line buffered or not wrap the stream if it’s not line buffered. In fact, this was already helpful during development of this change. Without it, I possibly would have forgot that WriteAllWrapper needs to be ignored for the check, leading to unnecessary wrapping if stdout is unbuffered. The alternative would have been to always wrap unknown streams. However, I don’t think that anyone would benefit from being less strict. We can expect streams from the standard library to be subclassing either io.RawIOBase or io.BufferedIOBase, so running Mercurial in the standard way should not regress by this change. Py2exe might replace sys.stdout and sys.stderr, but that currently breaks Mercurial anyway and also these streams don’t claim to be interactive, so this function is not called for them.

     1

Test temp file used with an editor has the expected suffix.

     2

     3

  $ hg init

     4

     5

Create an editor that writes its arguments to stdout and set it to $HGEDITOR.

     6

     7

  $ cat > editor.sh << EOF

     8

  > echo "\$@"

     9

  > exit 1

    10

  > EOF

    11

  $ hg add editor.sh

    12

  $ HGEDITOR="sh $TESTTMP/editor.sh"

    13

  $ export HGEDITOR

    14

    15

Verify that the path for a commit editor has the expected suffix.

    16

    17

  $ hg commit

    18

  *.commit.hg.txt (glob)

    19

  abort: edit failed: sh exited with status 1

    20

  [250]

    21

    22

Verify that the path for a histedit editor has the expected suffix.

    23

    24

  $ cat >> $HGRCPATH <<EOF

    25

  > [extensions]

    26

  > rebase=

    27

  > histedit=

    28

  > EOF

    29

  $ hg commit --message 'At least one commit for histedit.'

    30

  $ hg histedit

    31

  *.histedit.hg.txt (glob)

    32

  abort: edit failed: sh exited with status 1

    33

  [250]

    34

    35

Verify that when performing an action that has the side-effect of creating an

    36

editor for a diff, the file ends in .diff.

    37

    38

  $ echo 1 > one

    39

  $ echo 2 > two

    40

  $ hg add

    41

  adding one

    42

  adding two

    43

  $ hg commit --interactive --config ui.interactive=true --config ui.interface=text << EOF

    44

  > y

    45

  > e

    46

  > q

    47

  > EOF

    48

  diff --git a/one b/one

    49

  new file mode 100644

    50

  examine changes to 'one'?

    51

  (enter ? for help) [Ynesfdaq?] y

    52

    53

  @@ -0,0 +1,1 @@

    54

  +1

    55

  record change 1/2 to 'one'?

    56

  (enter ? for help) [Ynesfdaq?] e

    57

    58

  *.diff (glob)

    59

  editor exited with exit code 1

    60

  record change 1/2 to 'one'?

    61

  (enter ? for help) [Ynesfdaq?] q

    62

    63

  abort: user quit

    64

  [250]