procutil: make stream detection in make_line_buffered more correct and strict In make_line_buffered(), we don’t want to wrap the stream if we know that lines get flushed to the underlying raw stream already. Previously, the heuristic was too optimistic. It assumed that any stream which is not an instance of io.BufferedIOBase doesn’t need wrapping. However, there are buffered streams that aren’t instances of io.BufferedIOBase, like Mercurial’s own winstdout. The new logic is different in two ways: First, only for the check, if unwraps any combination of WriteAllWrapper and winstdout. Second, it skips wrapping the stream only if it is an instance of io.RawIOBase (or already wrapped). If it is an instance of io.BufferedIOBase, it gets wrapped. In any other case, the function raises an exception. This ensures that, if an unknown stream is passed or we add another wrapper in the future, we don’t wrap the stream if it’s already line buffered or not wrap the stream if it’s not line buffered. In fact, this was already helpful during development of this change. Without it, I possibly would have forgot that WriteAllWrapper needs to be ignored for the check, leading to unnecessary wrapping if stdout is unbuffered. The alternative would have been to always wrap unknown streams. However, I don’t think that anyone would benefit from being less strict. We can expect streams from the standard library to be subclassing either io.RawIOBase or io.BufferedIOBase, so running Mercurial in the standard way should not regress by this change. Py2exe might replace sys.stdout and sys.stderr, but that currently breaks Mercurial anyway and also these streams don’t claim to be interactive, so this function is not called for them.

     1

Test issue2761

     2

     3

  $ hg init

     4

     5

  $ touch to-be-deleted

     6

  $ hg add

     7

  adding to-be-deleted

     8

  $ hg ci -m first

     9

  $ echo a > to-be-deleted

    10

  $ hg ci -m second

    11

  $ rm to-be-deleted

    12

  $ hg diff -r 0

    13

    14

Same issue, different code path

    15

    16

  $ hg up -C

    17

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    18

  $ touch does-not-exist-in-1

    19

  $ hg add

    20

  adding does-not-exist-in-1

    21

  $ hg ci -m third

    22

  $ rm does-not-exist-in-1

    23

  $ hg diff -r 1