procutil: make stream detection in make_line_buffered more correct and strict In make_line_buffered(), we don’t want to wrap the stream if we know that lines get flushed to the underlying raw stream already. Previously, the heuristic was too optimistic. It assumed that any stream which is not an instance of io.BufferedIOBase doesn’t need wrapping. However, there are buffered streams that aren’t instances of io.BufferedIOBase, like Mercurial’s own winstdout. The new logic is different in two ways: First, only for the check, if unwraps any combination of WriteAllWrapper and winstdout. Second, it skips wrapping the stream only if it is an instance of io.RawIOBase (or already wrapped). If it is an instance of io.BufferedIOBase, it gets wrapped. In any other case, the function raises an exception. This ensures that, if an unknown stream is passed or we add another wrapper in the future, we don’t wrap the stream if it’s already line buffered or not wrap the stream if it’s not line buffered. In fact, this was already helpful during development of this change. Without it, I possibly would have forgot that WriteAllWrapper needs to be ignored for the check, leading to unnecessary wrapping if stdout is unbuffered. The alternative would have been to always wrap unknown streams. However, I don’t think that anyone would benefit from being less strict. We can expect streams from the standard library to be subclassing either io.RawIOBase or io.BufferedIOBase, so running Mercurial in the standard way should not regress by this change. Py2exe might replace sys.stdout and sys.stderr, but that currently breaks Mercurial anyway and also these streams don’t claim to be interactive, so this function is not called for them.

     1

#require no-msys # MSYS will translate web paths as if they were file paths

     2

     3

This is a test of the wire protocol over CGI-based hgweb.

     4

initialize repository

     5

     6

  $ hg init test

     7

  $ cd test

     8

  $ echo a > a

     9

  $ hg ci -Ama

    10

  adding a

    11

  $ cd ..

    12

  $ cat >hgweb.cgi <<HGWEB

    13

  > #

    14

  > # An example CGI script to use hgweb, edit as necessary

    15

  > import cgitb

    16

  > cgitb.enable()

    17

  > from mercurial import demandimport; demandimport.enable()

    18

  > from mercurial.hgweb import hgweb

    19

  > from mercurial.hgweb import wsgicgi

    20

  > application = hgweb(b"test", b"Empty test repository")

    21

  > wsgicgi.launch(application)

    22

  > HGWEB

    23

  $ chmod 755 hgweb.cgi

    24

    25

try hgweb request

    26

    27

  $ . "$TESTDIR/cgienv"

    28

  $ QUERY_STRING="cmd=changegroup&roots=0000000000000000000000000000000000000000"; export QUERY_STRING

    29

  $ "$PYTHON" hgweb.cgi >page1 2>&1

    30

  $ "$PYTHON" "$TESTDIR/md5sum.py" page1

    31

  1f424bb22ec05c3c6bc866b6e67efe43  page1

    32

    33

make sure headers are sent even when there is no body

    34

    35

  $ QUERY_STRING="cmd=listkeys&namespace=nosuchnamespace" "$PYTHON" hgweb.cgi

    36

  Status: 200 Script output follows\r (esc)

    37

  Content-Type: application/mercurial-0.1\r (esc)

    38

  Content-Length: 0\r (esc)

    39

  \r (esc)