Mercurial Mercurial > mercurial / annotate
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
tests/test-check-pytype.t
author Manuel Jacob <me@manueljacob.de>
Mon, 11 Jul 2022 01:51:20 +0200
branchstable
changeset 49378 094a5fa3cf52
parent 49019 455dce344c56
permissions -rw-r--r--
procutil: make stream detection in make_line_buffered more correct and strict In make_line_buffered(), we don’t want to wrap the stream if we know that lines get flushed to the underlying raw stream already. Previously, the heuristic was too optimistic. It assumed that any stream which is not an instance of io.BufferedIOBase doesn’t need wrapping. However, there are buffered streams that aren’t instances of io.BufferedIOBase, like Mercurial’s own winstdout. The new logic is different in two ways: First, only for the check, if unwraps any combination of WriteAllWrapper and winstdout. Second, it skips wrapping the stream only if it is an instance of io.RawIOBase (or already wrapped). If it is an instance of io.BufferedIOBase, it gets wrapped. In any other case, the function raises an exception. This ensures that, if an unknown stream is passed or we add another wrapper in the future, we don’t wrap the stream if it’s already line buffered or not wrap the stream if it’s not line buffered. In fact, this was already helpful during development of this change. Without it, I possibly would have forgot that WriteAllWrapper needs to be ignored for the check, leading to unnecessary wrapping if stdout is unbuffered. The alternative would have been to always wrap unknown streams. However, I don’t think that anyone would benefit from being less strict. We can expect streams from the standard library to be subclassing either io.RawIOBase or io.BufferedIOBase, so running Mercurial in the standard way should not regress by this change. Py2exe might replace sys.stdout and sys.stderr, but that currently breaks Mercurial anyway and also these streams don’t claim to be interactive, so this function is not called for them.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
46898
e1d75c514ced tests: add a (very slow) test that executes pytype
Matt Harbison <matt_harbison@yahoo.com>
parents:
diff changeset 
     1
 
#require pytype py3 slow
e1d75c514ced tests: add a (very slow) test that executes pytype
Matt Harbison <matt_harbison@yahoo.com>
parents:
diff changeset 
     2
 












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




     3


  $ cd $RUNTESTDIR/..












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




     4














e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




     5


Many of the individual files that are excluded here confuse pytype












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




     6


because they do a mix of Python 2 and Python 3 things












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




     7


conditionally. There's no good way to help it out with that as far as












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




     8


I can tell, so let's just hide those files from it for now. We should












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




     9


endeavor to empty this list out over time, as some of these are












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    10


probably hiding real problems.












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    11














e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    12


mercurial/bundlerepo.py       # no vfs and ui attrs on bundlerepo












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    13


mercurial/context.py          # many [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    14


mercurial/crecord.py          # tons of [attribute-error], [module-attr]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    15


mercurial/debugcommands.py    # [wrong-arg-types]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    16


mercurial/dispatch.py         # initstdio: No attribute ... on TextIO [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    17


mercurial/exchange.py         # [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    18


mercurial/hgweb/hgweb_mod.py  # [attribute-error], [name-error], [wrong-arg-types]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    19


mercurial/hgweb/server.py     # [attribute-error], [name-error], [module-attr]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    20


mercurial/hgweb/wsgicgi.py    # confused values in os.environ












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    21


mercurial/httppeer.py         # [attribute-error], [wrong-arg-types]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    22


mercurial/interfaces          # No attribute 'capabilities' on peer [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    23


mercurial/keepalive.py        # [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    24


mercurial/localrepo.py        # [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    25


mercurial/manifest.py         # [unsupported-operands], [wrong-arg-types]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    26


mercurial/minirst.py          # [unsupported-operands], [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    27


mercurial/pure/osutil.py      # [invalid-typevar], [not-callable]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    28


mercurial/pure/parsers.py     # [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    29


mercurial/repoview.py         # [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    30


mercurial/testing/storage.py  # tons of [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    31


mercurial/ui.py               # [attribute-error], [wrong-arg-types]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    32


mercurial/unionrepo.py        # ui, svfs, unfiltered [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    33


mercurial/win32.py            # [not-callable]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    34


mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    35


mercurial/wireprotov1peer.py  # [attribute-error]












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    36


mercurial/wireprotov1server.py  # BUG?: BundleValueError handler accesses subclass's attrs












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    37














e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    38


TODO: use --no-cache on test server?  Caching the files locally helps during












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    39


development, but may be a hinderance for CI testing.












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    40









49019






455dce344c56
pytype: drop py3.6 support



Matt Harbison <matt_harbison@yahoo.com>


parents: 
48491

diff
changeset




    41


  $ pytype -V 3.7 --keep-going --jobs auto mercurial \







46898






e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    42


  >    -x mercurial/bundlerepo.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    43


  >    -x mercurial/context.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    44


  >    -x mercurial/crecord.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    45


  >    -x mercurial/debugcommands.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    46


  >    -x mercurial/dispatch.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    47


  >    -x mercurial/exchange.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    48


  >    -x mercurial/hgweb/hgweb_mod.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    49


  >    -x mercurial/hgweb/server.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    50


  >    -x mercurial/hgweb/wsgicgi.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    51


  >    -x mercurial/httppeer.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    52


  >    -x mercurial/interfaces \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    53


  >    -x mercurial/keepalive.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    54


  >    -x mercurial/localrepo.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    55


  >    -x mercurial/manifest.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    56


  >    -x mercurial/minirst.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    57


  >    -x mercurial/pure/osutil.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    58


  >    -x mercurial/pure/parsers.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    59


  >    -x mercurial/repoview.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    60


  >    -x mercurial/testing/storage.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    61


  >    -x mercurial/thirdparty \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    62


  >    -x mercurial/ui.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    63


  >    -x mercurial/unionrepo.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    64


  >    -x mercurial/win32.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    65


  >    -x mercurial/wireprotoframing.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    66


  >    -x mercurial/wireprotov1peer.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    67


  >    -x mercurial/wireprotov1server.py \












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    68


  >  > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    69














e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    70


Only show the results on a failure, because the output on success is also












e1d75c514ced
tests: add a (very slow) test that executes pytype



Matt Harbison <matt_harbison@yahoo.com>


parents: 

diff
changeset




    71


voluminous and variable.














mercurial