procutil: make stream detection in make_line_buffered more correct and strict In make_line_buffered(), we don’t want to wrap the stream if we know that lines get flushed to the underlying raw stream already. Previously, the heuristic was too optimistic. It assumed that any stream which is not an instance of io.BufferedIOBase doesn’t need wrapping. However, there are buffered streams that aren’t instances of io.BufferedIOBase, like Mercurial’s own winstdout. The new logic is different in two ways: First, only for the check, if unwraps any combination of WriteAllWrapper and winstdout. Second, it skips wrapping the stream only if it is an instance of io.RawIOBase (or already wrapped). If it is an instance of io.BufferedIOBase, it gets wrapped. In any other case, the function raises an exception. This ensures that, if an unknown stream is passed or we add another wrapper in the future, we don’t wrap the stream if it’s already line buffered or not wrap the stream if it’s not line buffered. In fact, this was already helpful during development of this change. Without it, I possibly would have forgot that WriteAllWrapper needs to be ignored for the check, leading to unnecessary wrapping if stdout is unbuffered. The alternative would have been to always wrap unknown streams. However, I don’t think that anyone would benefit from being less strict. We can expect streams from the standard library to be subclassing either io.RawIOBase or io.BufferedIOBase, so running Mercurial in the standard way should not regress by this change. Py2exe might replace sys.stdout and sys.stderr, but that currently breaks Mercurial anyway and also these streams don’t claim to be interactive, so this function is not called for them.

     1

Some commands allow the user to specify a date, e.g.:

     2

     3

- backout, commit, import, tag: Specify the commit date.

     4

- log, revert, update: Select revision(s) by date.

     5

     6

Many date formats are valid. Here are some examples:

     7

     8

- ``Wed Dec 6 13:18:29 2006`` (local timezone assumed)

     9

- ``Dec 6 13:18 -0600`` (year assumed, time offset provided)

    10

- ``Dec 6 13:18 UTC`` (UTC and GMT are aliases for +0000)

    11

- ``Dec 6`` (midnight)

    12

- ``13:18`` (today assumed)

    13

- ``3:39`` (3:39AM assumed)

    14

- ``3:39pm`` (15:39)

    15

- ``2006-12-06 13:18:29`` (ISO 8601 format)

    16

- ``2006-12-6 13:18``

    17

- ``2006-12-6``

    18

- ``12-6``

    19

- ``12/6``

    20

- ``12/6/6`` (Dec 6 2006)

    21

- ``today`` (midnight)

    22

- ``yesterday`` (midnight)

    23

- ``now`` - right now

    24

    25

Lastly, there is Mercurial's internal format:

    26

    27

- ``1165411109 0`` (Wed Dec 6 13:18:29 2006 UTC)

    28

    29

This is the internal representation format for dates. The first number

    30

is the number of seconds since the epoch (1970-01-01 00:00 UTC). The

    31

second is the offset of the local timezone, in seconds west of UTC

    32

(negative if the timezone is east of UTC).

    33

    34

The log command also accepts date ranges:

    35

    36

- ``<DATE`` - at or before a given date/time

    37

- ``>DATE`` - on or after a given date/time

    38

- ``DATE to DATE`` - a date range, inclusive

    39

- ``-DAYS`` - within a given number of days from today