procutil: make stream detection in make_line_buffered more correct and strict In make_line_buffered(), we don’t want to wrap the stream if we know that lines get flushed to the underlying raw stream already. Previously, the heuristic was too optimistic. It assumed that any stream which is not an instance of io.BufferedIOBase doesn’t need wrapping. However, there are buffered streams that aren’t instances of io.BufferedIOBase, like Mercurial’s own winstdout. The new logic is different in two ways: First, only for the check, if unwraps any combination of WriteAllWrapper and winstdout. Second, it skips wrapping the stream only if it is an instance of io.RawIOBase (or already wrapped). If it is an instance of io.BufferedIOBase, it gets wrapped. In any other case, the function raises an exception. This ensures that, if an unknown stream is passed or we add another wrapper in the future, we don’t wrap the stream if it’s already line buffered or not wrap the stream if it’s not line buffered. In fact, this was already helpful during development of this change. Without it, I possibly would have forgot that WriteAllWrapper needs to be ignored for the check, leading to unnecessary wrapping if stdout is unbuffered. The alternative would have been to always wrap unknown streams. However, I don’t think that anyone would benefit from being less strict. We can expect streams from the standard library to be subclassing either io.RawIOBase or io.BufferedIOBase, so running Mercurial in the standard way should not regress by this change. Py2exe might replace sys.stdout and sys.stderr, but that currently breaks Mercurial anyway and also these streams don’t claim to be interactive, so this function is not called for them.

     1

"""collection of simple hooks for common tasks (EXPERIMENTAL)

     2

     3

This extension provides a number of simple hooks to handle issues

     4

commonly found in repositories with many contributors:

     5

- email notification when changesets move from draft to public phase

     6

- email notification when changesets are obsoleted

     7

- enforcement of draft phase for all incoming changesets

     8

- enforcement of a no-branch-merge policy

     9

- enforcement of a no-multiple-heads policy

    10

    11

The implementation of the hooks is subject to change, e.g. whether to

    12

implement them as individual hooks or merge them into the notify

    13

extension as option. The functionality itself is planned to be supported

    14

long-term.

    15

"""

    16

from . import (

    17

    changeset_obsoleted,

    18

    changeset_published,

    19

)

    20

    21

# configtable is only picked up from the "top-level" module of the extension,

    22

# so expand it here to ensure all items are properly loaded

    23

configtable = {}

    24

configtable.update(changeset_published.configtable)

    25

configtable.update(changeset_obsoleted.configtable)