procutil: make stream detection in make_line_buffered more correct and strict In make_line_buffered(), we don’t want to wrap the stream if we know that lines get flushed to the underlying raw stream already. Previously, the heuristic was too optimistic. It assumed that any stream which is not an instance of io.BufferedIOBase doesn’t need wrapping. However, there are buffered streams that aren’t instances of io.BufferedIOBase, like Mercurial’s own winstdout. The new logic is different in two ways: First, only for the check, if unwraps any combination of WriteAllWrapper and winstdout. Second, it skips wrapping the stream only if it is an instance of io.RawIOBase (or already wrapped). If it is an instance of io.BufferedIOBase, it gets wrapped. In any other case, the function raises an exception. This ensures that, if an unknown stream is passed or we add another wrapper in the future, we don’t wrap the stream if it’s already line buffered or not wrap the stream if it’s not line buffered. In fact, this was already helpful during development of this change. Without it, I possibly would have forgot that WriteAllWrapper needs to be ignored for the check, leading to unnecessary wrapping if stdout is unbuffered. The alternative would have been to always wrap unknown streams. However, I don’t think that anyone would benefit from being less strict. We can expect streams from the standard library to be subclassing either io.RawIOBase or io.BufferedIOBase, so running Mercurial in the standard way should not regress by this change. Py2exe might replace sys.stdout and sys.stderr, but that currently breaks Mercurial anyway and also these streams don’t claim to be interactive, so this function is not called for them.

     1

#!/bin/bash

     2

set -eu

     3

     4

if [[ "$PHABRICATOR_TOKEN" == "NO-PHAB" ]]; then

     5

    echo 'Skipping Phabricator Step' >&2

     6

    exit 0

     7

fi

     8

     9

revision_in_stack=`hg log \

    10

    --rev '.#stack and ::. and topic()' \

    11

    -T '\nONE-REV\n' \

    12

    | grep 'ONE-REV' | wc -l`

    13

revision_on_phab=`hg log \

    14

    --rev '.#stack and ::. and topic() and desc("re:\nDifferential Revision: [^\n]+D\d+$")'\

    15

    -T '\nONE-REV\n' \

    16

    | grep 'ONE-REV' | wc -l`

    17

    18

if [[ $revision_in_stack -eq 0 ]]; then

    19

    echo "stack is empty" >&2

    20

    exit 0

    21

fi

    22

    23

if [[ $revision_on_phab -eq 0 ]]; then

    24

    echo "no tracked diff in this stack" >&2

    25

    exit 0

    26

fi

    27

    28

if [[ $revision_on_phab -lt $revision_in_stack ]]; then

    29

    echo "not all stack changesets (${revision_in_stack}) have matching Phabricator Diff (${revision_on_phab})" >&2

    30

    exit 2

    31

fi

    32

    33

if [[ "$PHABRICATOR_TOKEN" == "" ]]; then

    34

    echo 'missing $PHABRICATOR_TOKEN variable' >&2

    35

    echo '(use PHABRICATOR_TOKEN="NO-PHAB" to disable this step)' >&2

    36

    exit 2

    37

fi

    38

    39

hg \

    40

--config extensions.phabricator= \

    41

--config phabricator.url=https://phab.mercurial-scm.org/ \

    42

--config phabricator.callsign=HG \

    43

--config auth.phabricator.schemes=https \

    44

--config auth.phabricator.prefix=phab.mercurial-scm.org \

    45

--config auth.phabricator.phabtoken=$PHABRICATOR_TOKEN \

    46

phabsend --rev '.#stack and ::. and topic()' \

    47

"$@"