procutil: make stream detection in make_line_buffered more correct and strict In make_line_buffered(), we don’t want to wrap the stream if we know that lines get flushed to the underlying raw stream already. Previously, the heuristic was too optimistic. It assumed that any stream which is not an instance of io.BufferedIOBase doesn’t need wrapping. However, there are buffered streams that aren’t instances of io.BufferedIOBase, like Mercurial’s own winstdout. The new logic is different in two ways: First, only for the check, if unwraps any combination of WriteAllWrapper and winstdout. Second, it skips wrapping the stream only if it is an instance of io.RawIOBase (or already wrapped). If it is an instance of io.BufferedIOBase, it gets wrapped. In any other case, the function raises an exception. This ensures that, if an unknown stream is passed or we add another wrapper in the future, we don’t wrap the stream if it’s already line buffered or not wrap the stream if it’s not line buffered. In fact, this was already helpful during development of this change. Without it, I possibly would have forgot that WriteAllWrapper needs to be ignored for the check, leading to unnecessary wrapping if stdout is unbuffered. The alternative would have been to always wrap unknown streams. However, I don’t think that anyone would benefit from being less strict. We can expect streams from the standard library to be subclassing either io.RawIOBase or io.BufferedIOBase, so running Mercurial in the standard way should not regress by this change. Py2exe might replace sys.stdout and sys.stderr, but that currently breaks Mercurial anyway and also these streams don’t claim to be interactive, so this function is not called for them.

     1

# Base Revsets to be used with revsetbenchmarks.py script

     2

#

     3

# The goal of this file is to gather a limited amount of revsets that allow a

     4

# good coverage of the internal revsets mechanisms.  Revsets included should not

     5

# be selected for their individual implementation, but for what they reveal of

     6

# the internal implementation of smartsets classes (and their interactions).

     7

#

     8

# Use and update this file when you change internal implementation of these

     9

# smartsets classes. Please include a comment explaining what each of your

    10

# addition is testing. Also check if your changes to the smartset class makes

    11

# some of the tests inadequate and replace them with a new one testing the same

    12

# behavior.

    13

#

    14

# If you want to benchmark revsets predicate itself, check 'all-revsets.txt'.

    15

#

    16

# The current content of this file is currently likely not reaching this goal

    17

# entirely, feel free, to audit its content and comment on each revset to

    18

# highlight what internal mechanisms they test.

    19

    20

all()

    21

draft()

    22

::tip

    23

draft() and ::tip

    24

::tip and draft()

    25

0::tip

    26

roots(0::tip)

    27

author(lmoscovicz)

    28

author(olivia)

    29

author(lmoscovicz) or author(olivia)

    30

author(olivia) or author(lmoscovicz)

    31

tip:0

    32

0::

    33

# those two `roots(...)` inputs are close to what phase movement use.

    34

roots((tip~100::) - (tip~100::tip))

    35

roots((0::) - (0::tip))

    36

42:68 and roots(42:tip)

    37

::p1(p1(tip))::

    38

public()

    39

:10000 and public()

    40

draft()

    41

:10000 and draft()

    42

roots((0:tip)::)

    43

(not public() - obsolete())

    44

(_intlist('20000\x0020001')) and merge()

    45

parents(20000)

    46

(20000::) - (20000)

    47

# The one below is used by rebase

    48

(children(ancestor(tip~5, tip)) and ::(tip~5))::

    49

heads(commonancestors(last(head(), 2)))

    50

heads(-10000:-1)

    51

roots(-10000:-1)

    52

only(max(head()), min(head()))